1189676 - [Download Manager]The "Delete" icon in "Edit downloads" page doesn't work.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Download, defect)

Description

[SandKing]

Attachment: Bug log: logcat_1803.txt

[1.Description]:
[Aries KK v2.5][Flame v2.5][Download Manager]When user wants to delect downloaded file from  "Download manager", you can see the "Delete" icon is  unavailable in "Edit downloads" page.
See video:"Aries_v2.5.3GP"
See log:"logcat_1803.txt"
Found Time:18:03

[2.Testing Steps]: 
1. Download something from Browser.
2. Launch "Settings"->"Downloads".
3. Press "multiple select" button.
4. Check some downloaded file.
5. Tap the "Delete" icon at top-right.

[3.Expected Result]: 
5. The download file you select in step4 will be deleted successful.

[4.Actual Result]: 
5. The  "Delete" icon is  unavailable

[5.Reproduction build]: 
Device: Aries KK 2.5(Affected)
Build ID               20150728035120
Gaia Revision          14e32276025b0310d3e89027320cf4b2a24cedfb
Gaia Date              2015-07-27 16:43:18
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/33dc8a83cfc0
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150728.033538
Firmware Date          Tue Jul 28 03:35:46 UTC 2015
Bootloader             s1

Device: Flame KK 2.2(Unaffected)
Build ID               20150730032503
Gaia Revision          8f3749f875c5ed155ccbd630aa2ee4e8bc2a9400
Gaia Date              2015-07-29 14:28:57
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e2a82fd90bc5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150730.072830
Firmware Date          Thu Jul 30 07:28:41 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5(Affected)
Build ID               20150730150205
Gaia Revision          7e7e92fbeea90cad8bf6f494b1a73712f79178e8
Gaia Date              2015-07-30 17:03:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/23e525e2ba35
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150730.183847
Firmware Date          Thu Jul 30 18:38:56 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[SandKing]

Attachment: Bug video: Aries_v2.5.3GP

Comment 2

[SandKing]

[Blocking Requested - why for this release]:

Major identifiable regressions

Comment 3

[Annabelle]

b2g-inbound Regression Window:

Last Working Environmental Variables
Flame KK 2.5:
Build ID               20150713074843
Gaia Revision          0585f7ec07d0ed12f5bb53e051d01d33b91288cb
Gaia Date              2015-07-13 11:06:54
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/6ad0aee8c595
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150714.044401
Firmware Date          Tue Jul 14 04:44:12 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Environmental Variables
Flame KK 2.5:
Build ID               20150713080743
Gaia Revision          b6ab914d2f8c1f56c0798e35d32507ab0af4c597
Gaia Date              2015-07-13 14:48:16
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/37f0cd531c58
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150714.044401
Firmware Date          Tue Jul 14 04:44:12 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia Revision          b6ab914d2f8c1f56c0798e35d32507ab0af4c597
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/6ad0aee8c595

First Broken Gecko & Last Working Gaia – issue DOES NOT repro
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/37f0cd531c58
Gaia Revision          0585f7ec07d0ed12f5bb53e051d01d33b91288cb

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/0585f7ec07d0ed12f5bb53e051d01d33b91288cb...b6ab914d2f8c1f56c0798e35d32507ab0af4c597

Comment 4

[Gregor Wagner [:gwagner]]

Reza, can this be related to bug 1176909?

Comment 5

[Reza Akhavan [:jedireza]]

:gwagner I don't think so. The other bug is related to the dialog being clipped by the software home button. I followed the steps to reproduce this bug, and the delete button is in the top right. It's there, it's enabled, but it just doesn't work. Saying it's unavailable may not have been the best way to describe it.

Comment 6

[Gregor Wagner [:gwagner]]

(In reply to Reza Akhavan [:jedireza] from comment #5)
> :gwagner I don't think so. The other bug is related to the dialog being
> clipped by the software home button. I followed the steps to reproduce this
> bug, and the delete button is in the top right. It's there, it's enabled,
> but it just doesn't work. Saying it's unavailable may not have been the best
> way to describe it.

Well it works with https://github.com/mozilla-b2g/gaia/commit/4ff6ec7ea4ccf76f891bc5cb7b28d0376c852535 and its broken with your commit. All yours :)

Comment 7

[SandKing]

The “refresh” button of the stopped file in Download list also does not work

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] jedireza:download-dialog > mozilla-b2g:master

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8650229 [details] [review]
[gaia] jedireza:download-dialog > mozilla-b2g:master

albertopq should review this; I am not familiar with this enough.

Comment 10

[Alberto Pastor [:albertopq]]

Comment on attachment 8650229 [details] [review]
[gaia] jedireza:download-dialog > mozilla-b2g:master

Did a small comment in github.

I tried the patch and didn't seem to work for me. After deleting one file, it goes to an empty screen which I cannot go back from :S
Did you see that as well?

At the other hand, we need unit tests covering for any change.

Please, flag me again when ready (or ni me if any question). Thanks!

Comment 11

[Reza Akhavan [:jedireza]]

> I tried the patch and didn't seem to work for me. After deleting one file,
> it goes to an empty screen which I cannot go back from :S
> Did you see that as well?

Nope. I just tested it and got the expected behavior. Although there have been some updates to the downloads screen recently.

I'll get tests added and ping you again. Thanks! :)

Comment 12

[Reza Akhavan [:jedireza]]

Comment on attachment 8650229 [details] [review]
[gaia] jedireza:download-dialog > mozilla-b2g:master

Alberto, I've updated the syntax as you mentioned on GitHub and added a test.

Comment 13

[Alberto Pastor [:albertopq]]

Comment on attachment 8650229 [details] [review]
[gaia] jedireza:download-dialog > mozilla-b2g:master

Works great! r=me as soon as the tests in Treeherder are green. Thanks!

Comment 14

[Reza Akhavan [:jedireza]]

Comment on attachment 8650229 [details] [review]
[gaia] jedireza:download-dialog > mozilla-b2g:master

Tests are all green :)

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=0ed05f390b53efc9a26e27b68aa49efa90517d40

Comment 15

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/aa6d7ff2b86a5e3f3cc377bcd6edb87d2ed4964a

Comment 17

[Annabelle]

Attachment: Verified_Aries_kk_v2.5.3gp

This bug has been verified as "Pass" on latest build of  Flame KK v2.5 & Aries KK v2.5 by the STR in Comment 0.
Actual results: The download file you select will be deleted successfully.
See attachment: Verified_Aries_kk_v2.5.3gp
Reproduce rate: 0/5

Device: Flame KK 2.5(Pass)
Build ID               20150827150209
Gaia Revision          d784c81961d82cbe9e111405468c590a8345856c
Gaia Date              2015-08-27 12:29:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ca086f9ef8bca2d6cdfa79bfc4c854f56a59859e
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150827.190412
Firmware Date          Thu Aug 27 19:04:26 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150827150209
Gaia Revision          d784c81961d82cbe9e111405468c590a8345856c
Gaia Date              2015-08-27 12:29:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ca086f9ef8bca2d6cdfa79bfc4c854f56a59859e
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150827.190412
Firmware Date          Thu Aug 27 19:04:26 EDT 2015
Bootloader             L1TC000118D0