Closed Bug 1189704 Opened 9 years ago Closed 9 years ago

Identity block, separator and URL move when URL is edited

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Version:
42 Branch
Platform:
x86_64
Windows 7
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 43
Iteration:
43.1 - Aug 24
Tracking Flags:
Tracking Status
firefox41 --- unaffected
firefox42 + verified
firefox43 + verified

People

(Reporter: Virtual, Assigned: Paolo)

References

Details

(Keywords: nightly-community, regression, Whiteboard: [fxprivacy])

Attachments

(5 files)

activated.png
7.34 KB, image/png
Details
not activated.png
7.69 KB, image/png
Details
activated [500%].png
14.15 KB, image/png
Details
not activated [500%].png
14.67 KB, image/png
Details
MozReview Request: Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins
40 bytes, text/x-review-board-request
bgrins
: review+
Sylvestre
: approval-mozilla-aurora+
Details 
I don;t know it was intended and it's relevant, but identity block isn't in center between separator and the go back button.
Summary: identity block, separator and URL moves when it's activated → identity block, separator and URL moves when URL bar it's activated
I don't see this on a recent Nightly on Windows 7. Are you using a custom theme or maybe a lightweight theme?
Flags: firefox-backlog?
Whiteboard: [fxprivacy]
I'm just using my lightweight theme (aka old Personas) named "Virtualfox", no custom full theme.
I forgot to add that you need to edit address, so for example delete "/" in the end of the URL to make it happen.
Summary: identity block, separator and URL moves when URL bar it's activated → identity block, separator and URL moves when URL bar it's edited
(In reply to Virtual_ManPL [:Virtual] from comment #0)
> Probably caused by Bug #1185362

Let's actually figure this out rather than guessing. Bug 1185362 isn't the only recent change in this area.
No longer blocks: 1185362
Keywords: regressionwindow-wanted
Summary: identity block, separator and URL moves when URL bar it's edited → Identity block, separator and URL move when URL is edited
Flags: firefox-backlog? → firefox-backlog+
Priority: -- → P2
Blocks: 1188565
[Tracking Requested - why for this release]: small but pretty obvious regression in primary UI
tracking-firefox42: --- → ?
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 43.1 - Aug 24
Flags: qe-verify?
Priority: P2 → P1
Looks like when reviewing bug 1185362 I missed that the shield animation margin had to be adjusted as the 2px margin was added between the lock and the shield icons.

I've also fixed the animation direction for RTL interfaces while here.
Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins
Attachment #8648707 - Flags: review?(bgrinstead)
Flags: qe-verify? → qe-verify+
Keywords: regressionwindow-wanted
Comment on attachment 8648707 [details]
MozReview Request: Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins

https://reviewboard.mozilla.org/r/16269/#review14531

Looks good, thanks.  Please update the commit message to say what the fix is doing rather than restating the problem
Attachment #8648707 - Flags: review?(bgrinstead) → review+
QA Contact: mwobensmith
https://hg.mozilla.org/mozilla-central/rev/b220196bb58d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Note that the right changeset for uplift is just this one:

https://hg.mozilla.org/integration/fx-team/rev/b220196bb58d
Requesting an uplift to 42, as this versions is also affected.
Flags: needinfo?(paolo.mozmail)
Comment on attachment 8648707 [details]
MozReview Request: Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins

Approval Request Comment
[Feature/regressing bug #]: Identity Block Redesign
[User impact if declined]: A noticeable two-pixel misalignment when the user starts typing
[Describe test coverage new/current, TreeHerder]: Landed on mozilla-central, awaiting QA. The entire Identity Block area is pending detailed QA on the Developer Edition channel anyways.
[Risks and why]: Alignment regressions for cases we didn't think about would be limited to the specific UI area
[String/UUID change made/needed]: None
Flags: needinfo?(paolo.mozmail)
Flags: needinfo?(bgrinstead)
Attachment #8648707 - Flags: approval-mozilla-aurora?
Comment on attachment 8648707 [details]
MozReview Request: Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins

Visual recent regression, taking it.
Attachment #8648707 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: