Closed
Bug 1189722
Opened 9 years ago
Closed 9 years ago
Const methods in TraceableVectorOperations hidden in MutableTraceableVectorOperations
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
3.14 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
I think claimed that it was a good idea to make MutableTraceableVectorOperations derive from TraceableVectorOperations. I forgot that declaring a non-const version of a method there would hide the const version in the base class though. Here's a patch to fix this. Added tests to exercise this, and to check that Rooted<TraceableVector<>> converts to handles correctly.
Attachment #8641637 -
Flags: review?(terrence)
|
||
Updated•9 years ago
|
Attachment #8641637 -
Flags: review?(terrence) → review+
|
||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c742ac2240c5
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•