Closed Bug 1189722 Opened 4 years ago Closed 4 years ago

Const methods in TraceableVectorOperations hidden in MutableTraceableVectorOperations

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

I think claimed that it was a good idea to make MutableTraceableVectorOperations derive from TraceableVectorOperations.  I forgot that declaring a non-const version of a method there would hide the const version in the base class though.

Here's a patch to fix this.  Added tests to exercise this, and to check that Rooted<TraceableVector<>> converts to handles correctly.
Attachment #8641637 - Flags: review?(terrence)
Attachment #8641637 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/c742ac2240c5
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.