1189758 - FindMyDevice leaks findmydevice.retry-count observers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[:gerard-majax]

+++ This bug was initially created as a clone of Bug #1189004 +++

See the memory reports in bug 1189004 and also bug 1189004 comment 9: there is system app/findmydevice code that is leaking mozSettings observers with the setting findmydevice.retry-count.

Comment 1

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #0)
> +++ This bug was initially created as a clone of Bug #1189004 +++
> 
> See the memory reports in bug 1189004 and also bug 1189004 comment 9: there
> is system app/findmydevice code that is leaking mozSettings observers with
> the setting findmydevice.retry-count.

Correction after carefully checking the about:memory report, this is leaking in the FindMyDevice app.

There are two call sites:
 - https://github.com/mozilla-b2g/gaia/blob/9a45076c37ad2139f25194613916af5efb55bbc7/apps/findmydevice/js/findmydevice.js#L174
 - https://github.com/mozilla-b2g/gaia/blob/9a45076c37ad2139f25194613916af5efb55bbc7/apps/findmydevice/js/findmydevice.js#L596

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] lissyx:bug1189758 > mozilla-b2g:master

Comment 3

[:gerard-majax]

Comment on attachment 8642020 [details] [review]
[gaia] lissyx:bug1189758 > mozilla-b2g:master

This should be enough, this way we should avoid leaking.

Comment 4

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8642020 [details] [review]
[gaia] lissyx:bug1189758 > mozilla-b2g:master

LGTM.

Thanks

Comment 5

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/39eceb7d224f3bebc98f8b6b3cc930fb051eb222