118979 - HTTP Accepts: should include MNG mimetype

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement)

Description

[Peter Janes]

Now that it's a supported format in the browser, Mozilla's HTTP "Accepts" header
should include video/x-mng, the MNG mimetype.

Comment 1

[Darin Fisher]

patch welcome :-)

Comment 2

[xyzzy]

I think bug 118838 is a dupe of this.

Comment 3

[Darin Fisher]

gerv?

Comment 4

[Gervase Markham [:gerv]]

Yes, it should. This is the one additional type we planned to add. No q value
(i.e. q=1.0). As Darin says, this is a trivial patch, which anyone can do :-)

Put it before image/png. While you are there, move text/plain after text/html
(for consistency), and remove all the spaces, as I'm pretty sure (unless Darin
wants to correct me) that they are not necessary. That'll shorten it a bit.

Gerv

Comment 5

[Peter Janes]

[e-mail] is right about the dup, btw.  (Technically it's a dup of
this one--bug 118838 is a symptom and this is the cause. :)  When I add
"video/x-mng" to user_pref("network.http.accept.default"), content negotiation
works and the file is displayed.

Comment 6

[Peter Janes]

Attachment: Trivial patch for HTTP Accepts

As Gervase says, anyone can handle this patch.	(Even me! :)

video/x-mng is added before image/png.	Also, per comments in the bug,
whitespace is removed and the position of text/plain is shifted.

Comment 7

[Darin Fisher]

Comment on attachment 64170 [details] [diff] [review]
Trivial patch for HTTP Accepts

sr=darin

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 64170 [details] [diff] [review]
Trivial patch for HTTP Accepts

r=bzbarsky

Peter, want me to check this in?

Comment 9

[Peter Janes]

Sure, please do.

Comment 10

[xyzzy]

*** Bug 118838 has been marked as a duplicate of this bug. ***

Comment 11

[Boris Zbarsky [:bzbarsky]]

checked in.

Comment 12

[tor]

Wasn't there discussion at some point to make the accept headers as small as
possible (ie, "*/*")?

If you're going to add all the image types, there's JNG, BMP, and ICO missing.

Comment 13

[Darin Fisher]

at one time, the accept header was */*, but it was decided to add a simple set
of static values to enable some limited degree of content negotiation.  the
current accept header is meant to reflect that.  moreover, we plan to have a
different accept header for requests that are known to result in images to help
reduce the size of the accept header.

Comment 14

[Gervase Markham [:gerv]]

Yes. I think sites will legitimately want to serve MNG if the browser supports
it, and animated GIF if not. 

Gerv