Seeing this on Bitbar, I haven't been able to reproduce myself, but I think I know what's going on here. http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/380/HTML_Report/ Traceback (most recent call last): File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/.env/local/lib/python2.7/site-packages/marionette_client-0.16-py2.7.egg/marionette/marionette_test.py", line 296, in run testMethod() File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_add_to_an_existing_contact_from_messages.py", line 50, in test_sms_add_number_to_existing_contact contact_details = contacts.contacts.tap() File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/tests/python/gaia-ui-tests/gaiatest/apps/contacts/app.py", line 138, in tap return self._return_class_from_tap(return_class) File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/tests/python/gaia-ui-tests/gaiatest/apps/contacts/app.py", line 148, in _return_class_from_tap return ContactDetails(self.marionette) File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/contact_details.py", line 29, in __init__ Wait(self.marionette).until(lambda m: el.location['x'] == 0) File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/.env/local/lib/python2.7/site-packages/marionette_driver-0.9-py2.7.egg/marionette_driver/wait.py", line 143, in until cause=last_exc) TimeoutException: TimeoutException: Timed out after 30.1 seconds
Comment on attachment 8641732 [details] [review] [gaia] mwargers:1189806 > mozilla-b2g:master I think this fixes it. This is used in more places when accessing conctacts. But I think it would make sense that when accessing a contact entry, we would automatically call this function. I could do that in a follow-up bug.
Comment on attachment 8641732 [details] [review] [gaia] mwargers:1189806 > mozilla-b2g:master added a minor comment, i think way it is now might be better.
Attachment #8641732 - Flags: review?(npark) → review+
My thought was more of in the line when accessing the contact property of the contacts app. But anyway, I'll file a follow-up bug on that.
Comment on attachment 8641732 [details] [review] [gaia] mwargers:1189806 > mozilla-b2g:master Including contacts.wait_for_contacts() in contacts.launch() might be a good thing. We could change that in every app, though. Like: > App.launch(wait_for_element_to_appear=0). I don't mind keeping the patch as is, because we've done the same thing all over the code base.
Attachment #8641732 - Flags: review?(jlorenzo) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
I filed bug 1190441 as a follow-up.
You need to log in before you can comment on or make changes to this bug.