Closed Bug 1189828 Opened 9 years ago Closed 9 years ago

Repo permissions script should ignore ENOENT errors

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file)

MozReview Request: scripts/repo-permissions: ignore ENOENT (bug 1189828); r?fubar
40 bytes, text/x-review-board-request
fubar
: review+
Details 
A CRON log indicated a failure changing permissions of the .hg/store/lock file because the file disappeared. We should probably ignore ENOENT errors when adjusting permissions to avoid race conditions. We should also verify that adjusting permissions on the lock file is sane while we're here.
scripts/repo-permissions: ignore ENOENT (bug 1189828); r?fubar

We periodically saw failures in production due to ENOENT. I think this
was always on .hg/store/lock files. This is a race condition and
disappearing files is harmless.

This commit ignores failures due to ENOENT.
Attachment #8683250 - Flags: review?(klibby)
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment on attachment 8683250 [details]
MozReview Request: scripts/repo-permissions: ignore ENOENT (bug 1189828); r?fubar

https://reviewboard.mozilla.org/r/24235/#review21721

lgtm
Attachment #8683250 - Flags: review?(klibby) → review+
Will deploy shortly.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: