1189960 - One-click diff view from bugzilla comments referencing a patch

Status: RESOLVED DUPLICATE of bug 1224631

(bugzilla.mozilla.org Graveyard :: Extensions: MozReview Integration, defect, P3)

Description

[Botond Ballo [:botond]]

Bug 1123143 added a direct link to the diff for each patch in the "MozReview Requests" widget in bugzilla.

This is great because it preserves the ability to navigate from the bug to a diff in one click.

However, with patches, you could perform such a one-click navigation from any comment referencing the patch as well. It would be great if we could also do that for a comment referencing a MozReview attachment.

Comment 1

[Gregory Szorc [:gps]]

This is a BMO feature request.

Comment 2

[Mark Côté [:mcote]]

Just to repeat what I also said in bug 1208750, this is a good idea because, if you're coming from an attachment URL, then that means you're probably a reviewer, so the diff is probably more important (reviews being more important for the patch author).  A simple fix is storing the URL to the diff in the attachment instead of to the reviews.  We'll need to verify that the logic behind presenting MozReview links explicitly in review-request mail still works (it should be to the diff as well).

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Is this not a matter of updating the MozReview Bugzilla Client's post_rb_url function to use the diff viewer URL instead of the review request URL, or am I oversimplifying this?

Comment 4

[Mark Côté [:mcote]]

It's very simple.  I'm actually bundling it with another small fix.  I'm going to submit the review request next week.

Comment 5

[Mark Côté [:mcote]]

botond: There's now a link to the diff when a patch is posted (and a link to the interdiff when it's updated).  Is this good for you?

Comment 6

[Botond Ballo [:botond]]

Yes - thanks! Please feel free to dupe this over to whichever bug added that link.

Comment 7

[Mark Côté [:mcote]]

Groovy. :)  Note that there was a bit of a regression; see bug 1232894, which I'm fixing now.

Comment 8

[Botond Ballo [:botond]]

(In reply to Mark Côté [:mcote] from comment #5)
> botond: There's now a link to the diff when a patch is posted (and a link to
> the interdiff when it's updated).  Is this good for you?

Hmm, actually I realized that what was implemented goes part way to what I'd like, but not all the way there.

It seems currently the one-click-to-diff link is only present for comments triggered by the creation or update of a patch. I would also like to have one for comments referencing a patch. An example would be [1] - I currently need two clicks to get to the diff from that comment, whereas with a comparable Splinter comment I'd only need one.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1238137#c28

Comment 9

[Nathan Froyd [:froydnj]]

(In reply to Botond Ballo [:botond] from comment #8)
> It seems currently the one-click-to-diff link is only present for comments
> triggered by the creation or update of a patch. I would also like to have
> one for comments referencing a patch. An example would be [1] - I currently
> need two clicks to get to the diff from that comment, whereas with a
> comparable Splinter comment I'd only need one.

Clicking on the "attachment NNNNN" link in that comment looks like it gets you to the right place?

Comment 10

[Botond Ballo [:botond]]

Oh, you're right! (I just looked at the tooltip of the link, saw that it wasn't the "#index_header" link, and assumed it wasn't what I wanted; in fact, it redirects to that link.)

Please ignore me, then :)