1189971 - Add primary UI preference to disable zoomed view

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Mark Capella [:capella]]

Attachment: bug1189971.diff

I'd find this convenient, while it's implementation improves :-)

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8641952 [details] [diff] [review]
bug1189971.diff

Review of attachment 8641952 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/xml/preferences_display.xml
@@ +32,5 @@
>      <CheckBoxPreference android:key="browser.ui.zoom.force-user-scalable"
>                          android:title="@string/pref_zoom_force_enabled"
>                          android:summary="@string/pref_zoom_force_enabled_summary" />
>  
> +    <CheckBoxPreference android:key="ui.zoomedview.disabled"

Drive-by: this preference needs to be removed on non-Nightly (or whatever flag we're using to prevent it from riding the trains). See GeckoPreferences.setupPreferences:

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/GeckoPreferences.java?rev=f5951ec72042#669

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Mark, if you don't want to finish this, feel free to unassign yourself and I assume it'll get triaged.

Comment 4

[Mark Capella [:capella]]

Just finished the try push ...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=41792cc45179

Was heading to fx-team ...

you want me this available on nightly only?

Are you in a hurry? Not sure what you're asking in comment #3 ... (?)

Comment 5

[Mark Capella [:capella]]

Attachment: bug1189971.diff

In any case, I think this is the tweak you're asking for :)

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Mark Capella [:capella] from comment #4)
> Are you in a hurry? Not sure what you're asking in comment #3 ... (?)

You didn't assign yourself so I wasn't sure if you intended to add additional patches, or if you were just attaching your WIP - from the additional patch, I think I've figured it out though. :P

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8642598 [details] [diff] [review]
bug1189971.diff

Review of attachment 8642598 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not too familiar with this process but this seems reasonable.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/475ca0b8da17

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/475ca0b8da17

Comment 10

[Francesco Lodolo [:flod]]

Nit: unwanted trailing whitespace?
http://hg.mozilla.org/mozilla-central/rev/475ca0b8da17#l1.14