Closed Bug 1189971 Opened 4 years ago Closed 4 years ago

Add primary UI preference to disable zoomed view

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed
fennec 42+ ---

People

(Reporter: blassey, Assigned: capella)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch bug1189971.diff (obsolete) — Splinter Review
I'd find this convenient, while it's implementation improves :-)
Attachment #8641952 - Flags: review?(blassey.bugs)
Attachment #8641952 - Flags: review?(blassey.bugs) → review+
Comment on attachment 8641952 [details] [diff] [review]
bug1189971.diff

Review of attachment 8641952 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/xml/preferences_display.xml
@@ +32,5 @@
>      <CheckBoxPreference android:key="browser.ui.zoom.force-user-scalable"
>                          android:title="@string/pref_zoom_force_enabled"
>                          android:summary="@string/pref_zoom_force_enabled_summary" />
>  
> +    <CheckBoxPreference android:key="ui.zoomedview.disabled"

Drive-by: this preference needs to be removed on non-Nightly (or whatever flag we're using to prevent it from riding the trains). See GeckoPreferences.setupPreferences:

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/GeckoPreferences.java?rev=f5951ec72042#669
Attachment #8641952 - Flags: review-
Mark, if you don't want to finish this, feel free to unassign yourself and I assume it'll get triaged.
Assignee: nobody → markcapella
Blocks: zoomedview
Summary: Add primary UI preference to disable magnifying glass → Add primary UI preference to disable zoomed view
Just finished the try push ...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=41792cc45179

Was heading to fx-team ...

you want me this available on nightly only?

Are you in a hurry? Not sure what you're asking in comment #3 ... (?)
Flags: needinfo?(michael.l.comella)
Attached patch bug1189971.diffSplinter Review
In any case, I think this is the tweak you're asking for :)
Attachment #8642598 - Flags: review?(michael.l.comella)
(In reply to Mark Capella [:capella] from comment #4)
> Are you in a hurry? Not sure what you're asking in comment #3 ... (?)

You didn't assign yourself so I wasn't sure if you intended to add additional patches, or if you were just attaching your WIP - from the additional patch, I think I've figured it out though. :P
Flags: needinfo?(michael.l.comella)
Comment on attachment 8642598 [details] [diff] [review]
bug1189971.diff

Review of attachment 8642598 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not too familiar with this process but this seems reasonable.
Attachment #8642598 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/475ca0b8da17
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
tracking-fennec: ? → 42+
You need to log in before you can comment on or make changes to this bug.