118999 - "Make Default Browser" prompt appears off screen

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ryan Farmer]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.7+) Gecko/20020109
BuildID:    20020109

When I started up todays Mozilla build, the "Make Default Browser" prompt,
appeared at the top left of my screen, running off screen in fact, leaving only
the option buttons visible.

Reproducible: Always
Steps to Reproduce:
1. Make another browser the defualt
2. Start Mozilla
3. When Mozilla starts, the "Make Default Browser" confirmation dialog box will
appear in the wrong place.

Comment 1

[sairuh (rarely reading bugmail)]

->bill

Comment 2

[WD]

Confirmed.  Win2k.   2002010903

Comment 3

[WD]

Also, for me at least...    Even if I do click "Yes", I get the same dialog
every time I launch Mozilla.

Comment 4

[Blake Ross]

Nominating for machv.

Comment 5

[WD]

*** Bug 119026 has been marked as a duplicate of this bug. ***

Comment 6

[Bill Law]

Something must have changed in nsIPrompt (or related code).

This may go away with the pending fix for bug 87257.

Comment 7

[Matthias Versen [:Matti]]

*** Bug 119089 has been marked as a duplicate of this bug. ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

*** Bug 119141 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 119208 has been marked as a duplicate of this bug. ***

Comment 10

[(not reading, please use [e-mail] instead)]

looking at nsWindowsHooks.cpp, we use the common dialog. [ConfirmEx()]

maybe the centering bug lies there?  or a bug in some lower level window code.

Comment 11

[Matthias Versen [:Matti]]

*** Bug 119238 has been marked as a duplicate of this bug. ***

Comment 12

[Dan M]

I recently changed the semantics of "centerscreen" for dependent windows: they
now interpret that as "center on parent." This dialog is given an incompletely
initialized parent window (the nascent initial browser window). It attempts to
center on it and ends up in a somewhat random position.

This could be fixed by removing the parent parameter sent by
checkForDefaultBrowser. But let me think about this one for a bit. Maybe I can
error-proof dependent window centering a little better.

Comment 13

[Bill Law]

That's what I suspected.  So the fix I mention in comment 6 should take care of
this problem.  Or at least the symptom.  Maybe this needs fixing to prevent it
cropping up again, though.

Comment 14

[Bill Law]

fixed along with 87257

Comment 15

[Matthias Versen [:Matti]]

*** Bug 119356 has been marked as a duplicate of this bug. ***

Comment 16

[R.K.Aa.]

*** Bug 119379 has been marked as a duplicate of this bug. ***

Comment 17

[R.K.Aa.]

*** Bug 119453 has been marked as a duplicate of this bug. ***