1190080 - [Windows 10] Jumplist icon almost not visible

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: jumplist.png

Windows 10 uses now a black background for the jumplists. This makes the dark Win7 icons almost invisible.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: jumplist.patch

I'm using now a separate image instead of mail-toolbar-aero.png. This gives us also the possibilty to remove this toolbar images as they are no longer needed with our svg images (I'll file a new bug to remove them).

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Patch applied on Win 10

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Patch applied on Win 7

Comment 4

[Richard Marti (:Paenglab)]

Attachment: jumplist.patch

The address book icon had a little bit a too small body (but not as the Win 7 screenshot shows, this was a cached icon from a previous version). Now made the body better visible.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Patch applied on Win 10

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Patch applied on Win 7

This is now showing the real icons. I had problems to show the correct icons as Windows cached the first version and didn't want to update to the latest.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8642063 [details] [diff] [review]
jumplist.patch

I don't have internet (except for about 30 minutes per day) for the next couple of weeks at least.  You should probably ask someone else for review…

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 8642063 [details] [diff] [review]
jumplist.patch

Jim, do you have time for a simple review? It's a simple change and the screenshots should be enough for the review.

Comment 9

[Jim Porter (:squib)]

Comment on attachment 8642063 [details] [diff] [review]
jumplist.patch

Review of attachment 8642063 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me. I think these icons look worse than the existing ones, but I suppose that's just because of the switch to SVG for all the toolbar icons...

Comment 10

[Richard Marti (:Paenglab)]

Attachment: jumplist.patch

Updated the reviewer in commit message.

Comment 11

[Richard Marti (:Paenglab)]

Attachment: jumplist.png for TB 38

If we want it for TB 38, we should use this image for the icons to fit the toolbar icons on TB 38.

If desired I can create a patch for ESR.

Comment 12

[aleth [:aleth]]

url:        https://hg.mozilla.org/comm-central/rev/b0a9ac1ed7f0ec7779022b36577f0eb3c1e5b9d1
changeset:  b0a9ac1ed7f0ec7779022b36577f0eb3c1e5b9d1
user:       Richard Marti <[e-mail]>
date:       Sat Aug 01 18:36:19 2015 +0200
description:
Bug 1190080 - Update the Jumplist icons for Windows 10. r=squib

Comment 13

[Richard Marti (:Paenglab)]

Comment on attachment 8642266 [details] [diff] [review]
jumplist.patch

[Approval Request Comment]
Regression caused by: Windows 10 uses a dark background for the jumplist
User impact if declined: almost invisible icons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, only changed icons

Comment 14

[Richard Marti (:Paenglab)]

Attachment: jumplist-ESR.patch

Patch with icons for ESR.

[Approval Request Comment]
Regression caused by: Windows 10 uses a dark background for the jumplist
User impact if declined: almost invisible icons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, only changed icons

Comment 15

[Richard Marti (:Paenglab)]

Attachment: jumplists with ESR patch

Comment 16

[Kent James (:rkent)]

Comment on attachment 8644962 [details] [diff] [review]
jumplist-ESR.patch

http://hg.mozilla.org/releases/comm-esr38/rev/0b02beb05d4c

Comment 17

[Kent James (:rkent)]

Comment on attachment 8642266 [details] [diff] [review]
jumplist.patch

https://hg.mozilla.org/releases/comm-beta/rev/0681e92bad2e