Use new String::Contains(char) method more widely

RESOLVED FIXED in Firefox 43

Status

()

--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: arnaud.bienner, Assigned: arnaud.bienner)

Tracking

Trunk
mozilla43
Points:
---

Firefox Tracking Flags

(firefox42 affected, firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1186603 introduced a new "Contains" method to check if a string contains a character or not.

This bug is about updated old code using "FindChar" with "Contains" where it makes sense to do so i.e. when "FindChar" is used only to check if a string contains a character.
(Assignee)

Updated

3 years ago
Depends on: 1186603
(Assignee)

Updated

3 years ago
Assignee: nobody → arnaud.bienner
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8648291 [details] [diff] [review]
bug1190086.patch

Nathan, could you please review this patch? (follow up from bug 1186603).
I searched for occurrences of FindChar with comparison to kNotFound, and when the result of FindChar isn't used afterwards.
Attachment #8648291 - Flags: review?(nfroyd)
(Assignee)

Comment 2

3 years ago
BTW I pushed this to try and I think it's OK:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e99486a5d1af
There are few tests failed, but not the same on every build, so I'm not sure it is related to my changes.
Comment on attachment 8648291 [details] [diff] [review]
bug1190086.patch

Review of attachment 8648291 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8648291 - Flags: review?(nfroyd) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fa26923ada0a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.