Closed Bug 1190092 Opened 5 years ago Closed 5 years ago

Zoom button cut off after startup if facet date view is unhidden

Categories

(Thunderbird :: Search, defect)

Product:
Thunderbird
Component:
Search
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 42.0

People

(Reporter: aleth, Assigned: aleth)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Fix, option 2
2.58 KB, patch
Paenglab
: review+
Details | Diff | Splinter Review 
The regression fix in bug 1160822 doesn't handle the case when the faceted search date visualisation is unhidden on startup, in which case the zoom button gets cut off (as overflow = hidden).
Attached patch Fix, option 1 (obsolete) — — Splinter Review 
This also improves a comment and makes the transition more snappy.

r?paenglab as Josiah has gone (who reviewed the previous patch)
Attachment #8642070 - Flags: review?(richard.marti)
Attached patch Fix, option 2 — — Splinter Review 
Alternative fix that flips the default state of overflow to 'visible' in the CSS.

Pick one ;)
Attachment #8642072 - Flags: review?(richard.marti)
Comment on attachment 8642070 [details] [diff] [review]
Fix, option 1

You are so mean and let me make a decision? ;)
Attachment #8642070 - Flags: review?(richard.marti) → review-
Comment on attachment 8642072 [details] [diff] [review]
Fix, option 2

I take option 2. :)
Attachment #8642072 - Flags: review?(richard.marti) → review+
Keywords: checkin-needed
Attachment #8642070 - Attachment is obsolete: true
url:        https://hg.mozilla.org/comm-central/rev/fb2d949696e85f6fa012c1f932755ecae3b7acc1
changeset:  fb2d949696e85f6fa012c1f932755ecae3b7acc1
user:       aleth <aleth@instantbird.org>
date:       Sat Aug 01 20:14:15 2015 +0200
description:
Bug 1190092 - Zoom button cut off after startup if facet date view is unhidden. r=paenglab
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0
You need to log in before you can comment on or make changes to this bug.