[Calendar] Convert checkboxes to gaia-checkbox component

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8642140 [details] [review]
[gaia] KevinGrandon:bug_1190140_calendar_checkboxes > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8642140 [details] [review]
[gaia] KevinGrandon:bug_1190140_calendar_checkboxes > mozilla-b2g:master

Gareth or Miller - could either of you review this one? This is necessary to get us off of building blocks, as we are deprecating usage of those. Thanks!
Attachment #8642140 - Flags: review?(mmedeiros)
Attachment #8642140 - Flags: review?(gaye)
Comment on attachment 8642140 [details] [review]
[gaia] KevinGrandon:bug_1190140_calendar_checkboxes > mozilla-b2g:master

LGTM, only needs to use a lighter font color for the calendar name (it's supposed to be #606060).
Attachment #8642140 - Flags: review?(mmedeiros)
Attachment #8642140 - Flags: review?(gaye)
Attachment #8642140 - Flags: review+
(Assignee)

Comment 4

3 years ago
Thanks for the review! Addressed the label color and landed in master: https://github.com/mozilla-b2g/gaia/commit/581de383687dc441a878d2c91a0167c6ec688fef
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.