Closed Bug 1190254 Opened 4 years ago Closed 4 years ago
use same conditions to call Reparent
Style Context in Restyle Undisplayed Nodes as in Restyle Self
We're currently using slightly different conditions to check whether it's safe to call ReparentStyleContext in RestyleUndisplayedNodes compared to RestyleSelf. I think we can use the same conditions (i.e., ignoring the eRestyle_Force and eRestyle_ForceDescendants bits (and after bug 1180118, the eRestyle_SomeDescendants bit)).
Are you comfortable reviewing this Mats? Picking you since you've messed around with undisplayed content (for the display:contents work) and this change is in RestyleUndisplayedContent. Note that it relies on the bug 1180118 patches that just landed on inbound. As far as I know, there's no reason we should be looking at different conditions than RestyleSelf does to determine whether it's safe to call ReparentStyleContext.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8642892 - Flags: review?(mats)
Comment on attachment 8642892 [details] [diff] [review] patch Yeah, I think this should use the same condition as RestyleSelf.
Attachment #8642892 - Flags: review?(mats) → review+
You need to log in before you can comment on or make changes to this bug.