TTest._runTest is a too long and complex method

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
3 years ago
a year ago

People

(Reporter: parkouss, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
TTest._runTest method in ttest.py is the method responsible to run a test. This is a hard job, and this is done in a big method  (454 lines at the moment).

It is really hard to read and understand what is done in here, and modifications in here often ends up as ugly code that tries to not interfere with other things around, as we can't understand how all this works easily.

We should rewrite this.
I think if we pull the spsprofiling stuff out it would help.  We could create a new file that manages that.
(Reporter)

Comment 2

3 years ago
I agree!

I have a question relative to sps profile. when it is used ? I can not see a try run that use that. (ie, that set something like "--spsProfile")
not many people set it, but it is used for investigating performance regressions on a fairly regular basis, it would be used like so:
try: -b o -p linux -u none -t all mozharness: --spsProfile
(Reporter)

Comment 4

3 years ago
(In reply to Joel Maher (:jmaher) from comment #3)
> not many people set it, but it is used for investigating performance
> regressions on a fairly regular basis, it would be used like so:
> try: -b o -p linux -u none -t all mozharness: --spsProfile

Thanks! So local only feature, it should be tested with that in mind.
(Reporter)

Updated

3 years ago
Depends on: 1190376
this is local and on try, we need to test both scenarios.

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.