Closed Bug 1190285 Opened 9 years ago Closed 9 years ago

MSG/driver clean out

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla42

Tracking Flags:

Tracking

Status

firefox42

---

fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(10 files)

unvirtualize MediaStream::AdvanceTimeVaryingValuesToCurrentTime() 9 years ago Karl Tomlinson (:karlt) 2.39 KB, patch	roc : review+	Details \| Diff \| Splinter Review
remove unused MediaStreamGraphImpl::GetAudioPosition() 9 years ago Karl Tomlinson (:karlt) 2.10 KB, patch	roc : review+	Details \| Diff \| Splinter Review
remove unused GetCurrentTime() 9 years ago Karl Tomlinson (:karlt) 4.87 KB, patch	padenot : review+	Details \| Diff \| Splinter Review
remove unused DispatchWhenNotEnoughBuffered 9 years ago Karl Tomlinson (:karlt) 5.44 KB, patch	padenot : review+	Details \| Diff \| Splinter Review
remove unused HaveEnoughBuffered 9 years ago Karl Tomlinson (:karlt) 8.73 KB, patch	padenot : review+	Details \| Diff \| Splinter Review
remove unused graph update indices 9 years ago Karl Tomlinson (:karlt) 11.40 KB, patch	roc : review+	Details \| Diff \| Splinter Review
move GetIntervalForIteration() from base class to ThreadedDriver, where it is used 9 years ago Karl Tomlinson (:karlt) 3.52 KB, patch	padenot : review+	Details \| Diff \| Splinter Review
move GraphTime definition to avoid GraphDriver.h includes 9 years ago Karl Tomlinson (:karlt) 3.52 KB, patch	padenot : review+	Details \| Diff \| Splinter Review
share ThreadedDriver interval update code 9 years ago Karl Tomlinson (:karlt) 7.57 KB, patch	padenot : review+	Details \| Diff \| Splinter Review
only update mStateComputedTime once per iteration 9 years ago Karl Tomlinson (:karlt) 2.23 KB, patch	padenot : review+	Details \| Diff \| Splinter Review

Karl Tomlinson (:karlt)

Assignee

Description

•

9 years ago

      No description provided.

Karl Tomlinson (:karlt)

Assignee

Comment 1

•

9 years ago

Attached patch unvirtualize MediaStream::AdvanceTimeVaryingValuesToCurrentTime() — Details — Splinter Review

Attachment #8642286 - Flags: review?(roc)

Karl Tomlinson (:karlt)

Assignee

Comment 2

•

9 years ago

Attached patch remove unused MediaStreamGraphImpl::GetAudioPosition() — Details — Splinter Review

GetAudioPosition() has been unused since revision 6eb9af883b3b.

Attachment #8642287 - Flags: review?(roc)

Karl Tomlinson (:karlt)

Assignee

Comment 3

•

9 years ago

Attached patch remove unused GetCurrentTime() — Details — Splinter Review

Attachment #8642289 - Flags: review?(padenot)

Karl Tomlinson (:karlt)

Assignee

Comment 4

•

9 years ago

Attached patch remove unused DispatchWhenNotEnoughBuffered — Details — Splinter Review

Attachment #8642290 - Flags: review?(padenot)

Karl Tomlinson (:karlt)

Assignee

Comment 5

•

9 years ago

Attached patch remove unused HaveEnoughBuffered — Details — Splinter Review

Attachment #8642291 - Flags: review?(padenot)

Karl Tomlinson (:karlt)

Assignee

Comment 6

•

9 years ago

Attached patch remove unused graph update indices — Details — Splinter Review

Attachment #8642292 - Flags: review?(roc)

Karl Tomlinson (:karlt)

Assignee

Comment 7

•

9 years ago

Attached patch move GetIntervalForIteration() from base class to ThreadedDriver, where it is used — Details — Splinter Review

Attachment #8642294 - Flags: review?(padenot)

Karl Tomlinson (:karlt)

Assignee

Comment 8

•

9 years ago

Attached patch move GraphTime definition to avoid GraphDriver.h includes — Details — Splinter Review

Attachment #8642295 - Flags: review?(padenot)

Karl Tomlinson (:karlt)

Assignee

Comment 9

•

9 years ago

Attached patch share ThreadedDriver interval update code — Details — Splinter Review

Attachment #8642296 - Flags: review?(padenot)

Karl Tomlinson (:karlt)

Assignee

Comment 10

•

9 years ago

Attached patch only update mStateComputedTime once per iteration — Details — Splinter Review

UpdateStateComputedTime(GraphTime aStateComputedTime) occurs midway during
the iteration, so there is no need to update at the end.

Attachment #8642297 - Flags: review?(padenot)

Karl Tomlinson (:karlt)

Assignee

Updated

•

9 years ago

Blocks: 1190291

Paul Adenot (:padenot)

Updated

•

9 years ago

Attachment #8642289 - Flags: review?(padenot) → review+

Paul Adenot (:padenot)

Updated

•

9 years ago

Attachment #8642291 - Flags: review?(padenot) → review+

Paul Adenot (:padenot)

Updated

•

9 years ago

Attachment #8642294 - Flags: review?(padenot) → review+

Paul Adenot (:padenot)

Updated

•

9 years ago

Attachment #8642295 - Flags: review?(padenot) → review+

Paul Adenot (:padenot)

Updated

•

9 years ago

Attachment #8642297 - Flags: review?(padenot) → review+

Paul Adenot (:padenot)

Updated

•

9 years ago

Attachment #8642296 - Flags: review?(padenot) → review+

Paul Adenot (:padenot)

Updated

•

9 years ago

Attachment #8642290 - Flags: review?(padenot) → review+

Karl Tomlinson (:karlt)

Assignee

Updated

•

9 years ago

Keywords: leave-open

Pulsebot

Comment 11

•

9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/e89ea131df69
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bcb21c74b74
https://hg.mozilla.org/integration/mozilla-inbound/rev/9db3e1d16ff5
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0fc6c3f48a7
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e7df6704c2c
https://hg.mozilla.org/integration/mozilla-inbound/rev/aae1fbf8c99a
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bc68d2d516e

Robert O'Callahan (:roc) (email my personal email if necessary)

Updated

•

9 years ago

Attachment #8642286 - Flags: review?(roc) → review+

Robert O'Callahan (:roc) (email my personal email if necessary)

Updated

•

9 years ago

Attachment #8642287 - Flags: review?(roc) → review+

Robert O'Callahan (:roc) (email my personal email if necessary)

Updated

•

9 years ago

Attachment #8642292 - Flags: review?(roc) → review+

Ryan VanderMeulen [:RyanVM]

Comment 12

•

9 years ago

https://hg.mozilla.org/mozilla-central/rev/e89ea131df69
https://hg.mozilla.org/mozilla-central/rev/2bcb21c74b74
https://hg.mozilla.org/mozilla-central/rev/9db3e1d16ff5
https://hg.mozilla.org/mozilla-central/rev/e0fc6c3f48a7
https://hg.mozilla.org/mozilla-central/rev/9e7df6704c2c
https://hg.mozilla.org/mozilla-central/rev/aae1fbf8c99a
https://hg.mozilla.org/mozilla-central/rev/3bc68d2d516e

Karl Tomlinson (:karlt)

Assignee

Updated

•

9 years ago

Keywords: leave-open

Karl Tomlinson (:karlt)

Assignee

Updated

•

9 years ago

Flags: in-testsuite-

Pulsebot

Comment 13

•

9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/d218034091a3
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed8acf929ceb
https://hg.mozilla.org/integration/mozilla-inbound/rev/abf5d2bbca2a

Carsten Book [:Tomcat]

Comment 14

•

9 years ago

https://hg.mozilla.org/mozilla-central/rev/d218034091a3
https://hg.mozilla.org/mozilla-central/rev/ed8acf929ceb
https://hg.mozilla.org/mozilla-central/rev/abf5d2bbca2a

Status: ASSIGNED → RESOLVED

Closed: 9 years ago

status-firefox42: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla42

You need to log in before you can comment on or make changes to this bug.