1190308 - [Aries KK]Picture shares to message automatically after locking screen and then switching to other app.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Alissa（leave from Mozilla）]

Attachment: logcat1.txt

[1.Description]:
[Aries KK][v2.5][Gallery]while we select which app to share picture, lock screen and switch to another app, and then back to gallery, message app will be selected automatically.
Found at:16:09
see attachment:logcat1.txt, Aries.png

[2.Testing Steps]: 
1.Launch Gallery.
2.Open a picture in full screen.[You can select more than one picture to reproduce this bug]
3.Tap share button.
4.Press "Power" button to turn off screen, press it again to bring screen up.
5.Switch left to camera.
6.Switch it back to "Gallery". 

[3.Expected Result]: 
6.Back to gallery share selecting page or back to gallery.

[4.Actual Result]: 
6.Picture shares to message input box automaticly.

[5.Reproduction build]: 
Device: Aries KK 2.5(Affected)
Build ID               20150801110932
Gaia Revision          2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gaia Date              2015-07-31 08:23:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/32712cd01159
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150801.105449
Firmware Date          Sat Aug  1 10:54:56 UTC 2015
Bootloader             s1

Device: Flame KK 2.2(Unaffected)
Build ID               20150802032509
Gaia Revision          f8b119ac30e97df991c97682ac4d4f9ca22e1793
Gaia Date              2015-07-31 13:20:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/429b9d2d4566
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150802.070658
Firmware Date          Sun Aug  2 07:07:09 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Devece: Flame v2.5(Unaffected):
Build ID               20150802150204
Gaia Revision          2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gaia Date              2015-07-31 08:23:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/32712cd01159
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150802.183402
Firmware Date          Sun Aug  2 18:34:15 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
10930

Comment 1

[Alissa（leave from Mozilla）]

Attachment: Aries.3gp

Comment 2

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:
Nominating since the picture is sent to the message box, without user's confirmation.  (Although it didn't actually sent out the picture)

Comment 3

[Hema Koka [:hema]]

broken function and unexpected reaction with picture sent to message box, blocking bug

Comment 4

[Hema Koka [:hema]]

Diego will investigate

Comment 5

[David Flanagan [:djf]]

When I follow the STR, the list of apps that to choose for the share has "RunWhatsApp" as the first choice, and when I swipe to go from camera back to gallery, I find that it is RunWhatsApp that launches, not the Messages app.  So this is not specific to Messages, but it is just the first item on the list that is selected.

This is clearly not a Gallery bug. I'm pretty sure it is a system app bug: some interaction between the code that displays the list of messages and the code that handles edge gestures. Someone should track that down.  But I'd suggest that we should also modify the system app so that if the user pushes the sleep button while an activity choice menu is displayed, the activity choice menu should go away as if they tapped cancel.  Note that pressing the Home button cancels an activity choice.  So should sleeping the phone.  Doing that will work around the issue, but may still leave the bug in the code.

Switching the component Gaia::System. Tim: with Alive gone, is there someone on your team who knows apps/system/js/activities.js and can take this bug? I don't think it is an area that Diego has any experience with.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I don't know where it got triggered either.

Attach a break point at https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/activities.js#L276 can tell where the mistaken confirmation is triggered.

Comment 7

[Etienne Segonzac (:etienne)]

(In reply to David Flanagan [:djf] from comment #5)
> This is clearly not a Gallery bug. I'm pretty sure it is a system app bug:
> some interaction between the code that displays the list of messages and the
> code that handles edge gestures. Someone should track that down.  But I'd
> suggest that we should also modify the system app so that if the user pushes
> the sleep button while an activity choice menu is displayed, the activity
> choice menu should go away as if they tapped cancel. 

The bug is still happening with edge gestures completely off so it's not an event forwarding issue.
Maybe a weird race with the lockscreen.

Anyway I think we should cancel the activity on lock, it's consistent with other choices we made. Sending a patch.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1190308 > mozilla-b2g:master

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8659999 [details] [review]
[gaia] etiennesegonzac:bug-1190308 > mozilla-b2g:master

The code looks good to me, but make sure all the tests are passing before landing.

Comment 10

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/80d340c2d6a6aa2abb77273b04efb2bd6909258c

Comment 11

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Arise KK v2.5 by the STR in comment 0.

Actual results: Press Power button to bring screen up, switch to camera, then swipe your finger from left to the right, it backs to gallery successfully.

See attachment: Verified_AriseKK_v2.5_Pic.3gp

Reproduce rate: 0/10

Device: Arise KK 2.5 (Pass)
Build ID               20150927001555
Gaia Revision          285486b417f1cb8316b19c0698a6655fc053fbd6
Gaia Date              2015-09-25 14:11:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150926.233607
Firmware Date          Sat Sep 26 23:36:15 UTC 2015
Bootloader             s1

Comment 12

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_AriseKK_v2.5_Pic.3gp