Closed
Bug 1190323
Opened 6 years ago
Closed 5 years ago
Test coverage for i18n extension API
Categories
(WebExtensions :: Untriaged, defect)
WebExtensions
Untriaged
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: gkrizsanits, Assigned: kmag)
References
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → kmaglione+bmo
Assignee | ||
Comment 1•5 years ago
|
||
This is still missing coverage for: * The |@@extension_id| message, both when the UUID should be available and when it shouldn't. * |localize| calls with an unknown message ID. * Locale data files with a non-object-literal as a top-level object, or messages with non-object values, or non-string "message" properties. * Locale data files which are not valid JSON. * A |default_locale| property which is does not match an included locale, or bundled locales but no |default_locale| property. https://people.mozilla.org/~kmaglione/webextension-test-coverage/toolkit/components/extensions/ExtensionUtils.jsm.html https://people.mozilla.org/~kmaglione/webextension-test-coverage/toolkit/components/extensions/Extension.jsm.html
Assignee | ||
Updated•5 years ago
|
Component: Extension Compatibility → WebExtensions
Product: Firefox → Toolkit
Assignee | ||
Comment 2•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/30223/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30223/
Attachment #8705880 -
Flags: review?(wmccloskey)
Assignee | ||
Comment 3•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/30225/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30225/
Attachment #8705881 -
Flags: review?(wmccloskey)
Comment on attachment 8705880 [details] MozReview Request: Bug 1190323: Part 1 - [webext] Fix @@extension_id locale string substitutions. r?billm https://reviewboard.mozilla.org/r/30223/#review27107
Attachment #8705880 -
Flags: review?(wmccloskey) → review+
Comment on attachment 8705881 [details] MozReview Request: Bug 1190323: [webext] Part 2: Complete i18n API test coverage. r?billm https://reviewboard.mozilla.org/r/30225/#review27111
Attachment #8705881 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 6•5 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/84e35904d56bbed4ac0776cd34911755698ec8fa Bug 1190323: Part 1 - [webext] Fix @@extension_id locale string substitutions. r=billm https://hg.mozilla.org/integration/fx-team/rev/c80a7fee53d9020d04ac673c845af7d6c19826c5 Bug 1190323: [webext] Part 2: Complete i18n API test coverage. r=billm
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/84e35904d56b https://hg.mozilla.org/mozilla-central/rev/c80a7fee53d9
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•3 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•