1190323 - Test coverage for i18n extension API

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Comment 1

[Kris Maglione [:kmag]]

This is still missing coverage for:

* The |@@extension_id| message, both when the UUID should be available and when it shouldn't.
* |localize| calls with an unknown message ID.
* Locale data files with a non-object-literal as a top-level object, or messages with non-object values, or non-string "message" properties.
* Locale data files which are not valid JSON.
* A |default_locale| property which is does not match an included locale, or bundled locales but no |default_locale| property.



https://people.mozilla.org/~kmaglione/webextension-test-coverage/toolkit/components/extensions/ExtensionUtils.jsm.html
https://people.mozilla.org/~kmaglione/webextension-test-coverage/toolkit/components/extensions/Extension.jsm.html

Comment 2

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1190323: Part 1 - [webext] Fix @@extension_id locale string substitutions. r?billm

Review commit: https://reviewboard.mozilla.org/r/30223/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30223/

Comment 3

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1190323: [webext] Part 2: Complete i18n API test coverage. r?billm

Review commit: https://reviewboard.mozilla.org/r/30225/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30225/

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8705880 [details]
MozReview Request: Bug 1190323: Part 1 - [webext] Fix @@extension_id locale string substitutions. r?billm

https://reviewboard.mozilla.org/r/30223/#review27107

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8705881 [details]
MozReview Request: Bug 1190323: [webext] Part 2: Complete i18n API test coverage. r?billm

https://reviewboard.mozilla.org/r/30225/#review27111

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/84e35904d56bbed4ac0776cd34911755698ec8fa
Bug 1190323: Part 1 - [webext] Fix @@extension_id locale string substitutions. r=billm

https://hg.mozilla.org/integration/fx-team/rev/c80a7fee53d9020d04ac673c845af7d6c19826c5
Bug 1190323: [webext] Part 2: Complete i18n API test coverage. r=billm

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/84e35904d56b
https://hg.mozilla.org/mozilla-central/rev/c80a7fee53d9