Closed Bug 1190328 Opened 9 years ago Closed 7 years ago

Test coverage for tabs extension API

Categories

(WebExtensions :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gkrizsanits, Unassigned)

References

Details

(Whiteboard: [tabs] triaged)

Blocks: 1185459
This is still missing coverage for:

* The |onCreated| and |onRemoved| events.
* The |onUpdated| event with an image change.
* The |onUpdated| progress listener with (stateFlags & Ci.nsIWebProgressListener.STATE_IS_WINDOW) ever being false.
* The |onLocationChange| listener with a "complete", rather than "loading", status.
* |tabs.create| without the |active| or |selected| states.
* |tabs.create| called before the browser window has fully loaded, and does not yet have a |gBrowser| global.
* |tabs.update| without an explicit tab ID.
* The |reload|, |getAllInWindow|, and |insertCSS| API methods.
* |tabs.query| with a non-matching |lastFocusedWindow| or |windowType| filter.
* The |_execute| method with |code|, |allFrames|, |matchAboutBlank|, and |runAt| properties.
* |tabs.connect| without an explicit |name|, or with a |frameId|.
* |tabs.sendMessage| with a |frameId|.

I think we should probably split this into several bugs.


https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-tabs.js.html
Component: Extension Compatibility → WebExtensions
Product: Firefox → Toolkit
Assignee: nobody → mwein
Depends on: 1245342
Depends on: 1245343
Depends on: 1245345
Depends on: 1245346
Depends on: 1245350
Depends on: 1245351
Depends on: 1245352
Depends on: 1245353
Depends on: 1245355
Flags: blocking-webextensions-
Flags: blocking-webextensions- → blocking-webextensions+
Iteration: --- → 47.2 - Feb 22
Iteration: 47.2 - Feb 22 → 47.3 - Mar 7
Iteration: 47.3 - Mar 7 → 48.1 - Mar 21
Depends on: 1257583
Iteration: 48.1 - Mar 21 → ---
Whiteboard: [tabs] triaged
Assignee: mwein → nobody
Component: WebExtensions: Untriaged → WebExtensions: General
Flags: blocking-webextensions+
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.