1190421 - Remove |hasPingBeenSent| from TelemetrySession.jsm

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Alessio Placitelli [:Dexter]]

|hasPingBeenSent| is defined but not being used anymore in TelemetrySession.jsm [1]. We should remove it.

[1] - https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/toolkit/components/telemetry/TelemetrySession.jsm#l908

Comment 1

[isangelawu]

Hello alessio, Could i take this as my first try to contribute

Comment 2

[Giovanny Gongora [:gioyik]]

Attachment: 1190421.patch

Comment 3

[Giovanny Gongora [:gioyik]]

Sorry isangelwau,

I didn't see your comment before submit the patch. :(

Comment 4

[Alessio Placitelli [:Dexter]]

Comment on attachment 8644803 [details] [diff] [review]
1190421.patch

Review of attachment 8644803 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for your contribution Giovanny, this looks good!

Did you push it to try already?

Comment 5

[Giovanny Gongora [:gioyik]]

No, I didn't because I don't know the try syntax for this patch. If you help me with the syntax I can push it to try server.

Thanks

Comment 6

[Alessio Placitelli [:Dexter]]

Sure, no problem! I'd suggest to use this "try: -b do -p all -u xpcshell -t none" to play safe ;)

Also, did you know about Try chooser [1]? It allows to build the correct try syntax by choosing from the various tests!

[1] - http://trychooser.pub.build.mozilla.org/

Comment 7

[Giovanny Gongora [:gioyik]]

Try and most of the servers are closed. But I used "try: -b do -p all -u xpcshell -t none CLOSED TREE", so, the try submission is this: 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ab1ba2329c1

> Also, did you know about Try chooser [1]? It allows to build the correct try syntax by choosing from the various tests!

I am always confused about which tests should run, for that reason I never check TryChooser first, I think I need more practice and experience with try chooser. :)

Thank you

Comment 8

[Giovanny Gongora [:gioyik]]

This one looks good to merge

Comment 9

[Georg Fritzsche [:gfritzsche]]

For future try runs it would be helpful if you use separate - empty - patch for the try syntax.
That way we can quickly see which patches were patches were pushed to try there and their messages :)

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bdea09cdb622

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bdea09cdb622