Closed Bug 1190424 Opened 9 years ago Closed 9 years ago

UITests fail when run on iPad Air

Categories

(Firefox for iOS :: Build & Test, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: fluffyemily, Assigned: fluffyemily)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
ClearPrivateDataTests -> testClearsTopSitesPanel() & testClearsHistoryPanel()
ToolbarTests -> testLandscapeNavigationWithTabSwitch() (Crashes tests)
HistoryTests -> testHistoryUI()

ClearPrivateDataTests failures caused by tab tray not refreshing when the modal settings is dismissed because when in form mode viewWillNotAppear is not called on iPad.
Attached file Pull request
Attachment #8642925 - Flags: review?(bnicholson)
Blocks: 1190871
Comment on attachment 8642925 [details] [review]
Pull request

Looks good -- just want to understand some things better before giving r+.
Attachment #8642925 - Flags: review?(bnicholson) → feedback+
Attachment #8642925 - Flags: review?(bnicholson)
Attachment #8642925 - Flags: review?(bnicholson)
Attachment #8642925 - Flags: review+
Attachment #8642925 - Flags: feedback+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: