Closed
Bug 1190472
Opened 6 years ago
Closed 5 years ago
MediaRawDataQueue::Push/PushFront should take && arguments to reduce refcounting
Categories
(Core :: Audio/Video, enhancement, P5)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: ayg, Assigned: froydnj)
References
Details
Attachments
(3 files)
5.04 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
896 bytes,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
2.18 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
(Nathan Froyd [:froydnj][:nfroyd] from bug 1179451 comment #32) > I wonder if these PushFront methods should take && arguments as well or > instead of pointer arguments, just to avoid unnecessary reference-counting. > File a followup bug?
Updated•6 years ago
|
Priority: -- → P5
![]() |
Assignee | |
Comment 1•6 years ago
|
||
I have patches for this, I'll post them tomorrow.
Assignee: nobody → nfroyd
![]() |
Assignee | |
Comment 2•5 years ago
|
||
OK, so "tomorrow" turned into "two weeks", but this is not exactly high-priority stuff. Sometimes when we push onto the queue, we don't need to hold a reference afterwards. In that case, we can pass the reference in and avoid unnecessary reference counting.
Attachment #8675747 -
Flags: review?(kinetik)
![]() |
Assignee | |
Comment 3•5 years ago
|
||
We don't call it, and it's not particularly efficient anyway.
Attachment #8675748 -
Flags: review?(kinetik)
![]() |
Assignee | |
Comment 4•5 years ago
|
||
In the one place we push a MediaRawDataQueue onto a MediaRawDataQueue, we don't use the pushee aftewards. It's more efficient to indicate that by using Move(), and we can then save on reference-counting things needlessly.
Attachment #8675749 -
Flags: review?(kinetik)
Updated•5 years ago
|
Attachment #8675747 -
Flags: review?(kinetik) → review+
Updated•5 years ago
|
Attachment #8675748 -
Flags: review?(kinetik) → review+
Updated•5 years ago
|
Attachment #8675749 -
Flags: review?(kinetik) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0d5a28ba9d4 https://hg.mozilla.org/integration/mozilla-inbound/rev/3c4316e8d12a https://hg.mozilla.org/integration/mozilla-inbound/rev/0e80a5538a67
Comment 6•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e0d5a28ba9d4 https://hg.mozilla.org/mozilla-central/rev/3c4316e8d12a https://hg.mozilla.org/mozilla-central/rev/0e80a5538a67
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment 7•5 years ago
|
||
Part3 incorrectly pushed to the wrong end of the queue. this broke webm playback whenever this code was called.
![]() |
Assignee | |
Comment 8•5 years ago
|
||
(In reply to Jean-Yves Avenard [:jya] from comment #7) > Part3 incorrectly pushed to the wrong end of the queue. this broke webm > playback whenever this code was called. Doh. Sorry about that. :(
You need to log in
before you can comment on or make changes to this bug.
Description
•