Closed
Bug 1190494
Opened 9 years ago
Closed 9 years ago
Update push_printurls hook to operate on repository relative path
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
Expect a patch shortly.
Assignee | ||
Comment 1•9 years ago
|
||
hghooks: deduce repository path from filesystem path (bug 1190494); r?RyanVM Before, we maintained a manual mapping of repository directory name to expanded path. This is a lot of extra work for something we can just grab from the filesystem. Refactor the hook to deduce the repository relative path from the repository's location on the filesystem, relative to a root directory. The test for an unknown repository not displaying info has been deleted because the hook is now globally installed.
Attachment #8642557 -
Flags: review?(ryanvm)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8642557 [details] MozReview Request: hghooks: deduce repository path from filesystem path (bug 1190494); r?RyanVM hghooks: deduce repository path from filesystem path (bug 1190494); r?RyanVM Before, we maintained a manual mapping of repository directory name to expanded path. This is a lot of extra work for something we can just grab from the filesystem. Refactor the hook to deduce the repository relative path from the repository's location on the filesystem, relative to a root directory. The test for an unknown repository not displaying info has been deleted because the hook is now globally installed.
Comment 3•9 years ago
|
||
Comment on attachment 8642557 [details] MozReview Request: hghooks: deduce repository path from filesystem path (bug 1190494); r?RyanVM https://reviewboard.mozilla.org/r/14729/#review13319 Ship It!
Attachment #8642557 -
Flags: review?(ryanvm) → review+
Assignee | ||
Comment 4•9 years ago
|
||
url: https://hg.mozilla.org/hgcustom/version-control-tools/rev/ffed96be1576ab3ee5dbde5ff5ce40fa628da4a9 changeset: ffed96be1576ab3ee5dbde5ff5ce40fa628da4a9 user: Gregory Szorc <gps@mozilla.com> date: Tue Aug 04 11:07:13 2015 -0700 description: hghooks: deduce repository path from filesystem path (bug 1190494); r=RyanVM Before, we maintained a manual mapping of repository directory name to expanded path. This is a lot of extra work for something we can just grab from the filesystem. Refactor the hook to deduce the repository relative path from the repository's location on the filesystem, relative to a root directory. The test for an unknown repository not displaying info has been deleted because the hook is now globally installed.
Assignee | ||
Comment 5•9 years ago
|
||
Deploying this now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•9 years ago
|
||
I've performed some pushes to version-control-tools today and the hook appears to be working as expected.
You need to log in
before you can comment on or make changes to this bug.
Description
•