1190512 - Improve job presentation logic for filtered (but selected) or collapsed job/groups

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder: Frontend, defect, P4)

Description

[Jonathan French (:jfrench)]

Follow up from review in PR759, for bug 1163064. Current workflows:

(scenario 1)
o select a *non unclassified-failure (eg. pending)
o toggle unclassified failures
Issue: you now have a selected job which can be retriggered, cancelled, etc, but you can't see it

(scenario 2, upcoming job chunking/grouping)
o click on the job group navbar toggle (expand)
o select a job chunk in an expanded job group and/or pin it
o click on the job group navbar toggle (collapse)
Issue: similar problem as scenario 1

Possible solutions:
- Deselect the job, perhaps provide a blue info thNotify 'Hidden job
deselected', and left/right/n/p navigation would continue from that position
- For job groups only, style the "+n" job element as selected (btn btn-lg-xform selected-job), etc) to imply it contains selected content, leave behavior as is for filtered jobs
- Leave behavior as is for all and mark this bug wontfix

Comment 1

[Ed Morley [:emorley]]

If I try that now, the job details panel stays showing, so the job being selected is still something the user can know. As such, I think there's nothing to do here.