Closed Bug 1190525 Opened 6 years ago Closed 6 years ago

"mach mercurial-setup" message should say "./mach mercurial-setup"

Categories

(Firefox Build System :: Mach Core, enhancement)

x86_64
Linux
enhancement
Not set
blocker

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: BenB, Assigned: gps)

Details

Attachments

(1 file)

Environment:
* Ubuntu 12.04 LTS
* hg 2.0.2
* mach 0.9.1

Last time I built Firefox, on 2015-06-29, all worked fine. I did hg pull -u, and make fails now:

-------------------

$ make -f client.mk 
*** MERCURIAL NOT CONFIGURED ***

mach has detected that you have never run `mach mercurial-setup`.

Running this command will ensure your Mercurial version control tool is up
to date and optimally configured for a better, more productive experience
when working on Mozilla projects.

Please run `mach mercurial-setup` now.

Note: `mach mercurial-setup` does not make any changes without prompting
you first.
client.mk:201: /.mozconfig.mk: Datei oder Verzeichnis nicht gefunden
*** MERCURIAL NOT CONFIGURED ***

mach has detected that you have never run `mach mercurial-setup`.

Running this command will ensure your Mercurial version control tool is up
to date and optimally configured for a better, more productive experience
when working on Mozilla projects.

Please run `mach mercurial-setup` now.

Note: `mach mercurial-setup` does not make any changes without prompting
you first.
python2.7 .../source/config/pythonpath.py -I .../source/testing/mozbase/mozfile \
	    .../source/python/mozbuild/mozbuild/controller/clobber.py .../source 
Usage: clobber.py topsrcdir topobjdir
make: *** [/CLOBBER] Fehler 1
$ mach mercurial-setup
No definition for packages found for 
$
-------------------

Actual result:
There's several things odd here:
- If I run |make|, it shouldn't require mach. "apt-get install mach", when installing on Ubuntu, also installs "rpm" and "yum" as package dependencies, which I don't want. I don't want "rpm" on a Debian system.
- It forces me to do some hg setup, which I have never needed and I don't see why I would need it. I am just building Firefox and fetching it from source control. I've been doing that for years, and "hg pull -u" did work just fine just now without these "recommended settings", so why do I need to run that hg setup at all? Even more so to build? When I have the source code, the job of hg is over. Also, what about people who use tarballs?
- The "mach mercurial-setup" command simply doesn't work. It exits with a broken error message. See above.

Expected result:
* I don't need mach
* I don't need any new setup of hg, at all
* I don't need any new setup of hg *to build*, *after* hg fetch
* "mach mercurial-setup" works

Severity:
Blocker. Can't compile (= Definition of "Blocker", according to <https://bugzilla.mozilla.org/page.cgi?id=fields.html#bug_severity>)

xref:
Bug 1185354 mach mercurial-setup should not be required for clobber/build
OS: Unspecified → Linux
Priority: -- → P1
Hardware: Unspecified → x86_64
Version: unspecified → Trunk
You should run `./mach`, not `mach`. The "mach" apt-get package is something else entirely.
We should fix the message there to explicitly say "./mach".

FWIW, "mach build" is the best-supported way to invoke a build nowadays. It's likely that we'll retire client.mk in the near future.
> You should run `./mach`, not `mach`. The "mach" apt-get package is something else entirely.

I did exactly what the message said:
"Please run `mach mercurial-setup` now."

> We should fix the message there to explicitly say "./mach".

Yeah, please! Thanks.

> FWIW, "mach build" is the best-supported way to invoke a build nowadays.
> It's likely that we'll retire client.mk in the near future.

Thanks for the hint. Works like a charm now. Thanks!
Priority: P1 → --
Summary: "mach mercurial-setup" doesn't work (and shouldn't be required at all) → "mach mercurial-setup" message should say "./mach mercurial-setup"
I'm glad that the "make chroot" mach package is not required!
Bug 1190525 - Print path to mach; r?smacleod
Attachment #8646500 - Flags: review?(smacleod)
Comment on attachment 8646500 [details]
MozReview Request: Bug 1190525 - Print path to mach; r?smacleod

https://reviewboard.mozilla.org/r/15789/#review14657

Ship It!
Attachment #8646500 - Flags: review?(smacleod) → review+
https://hg.mozilla.org/mozilla-central/rev/87c2a6949c17
Assignee: nobody → gps
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.