pykey.py: make key specification explicit in all cases (rather than implicit)

RESOLVED FIXED in Firefox 43

Status

()

Core
Security: PSM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: keeler, Assigned: keeler)

Tracking

Trunk
mozilla43
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox42 affected, firefox43 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
It would be helpful to add comments directly to the .certspec and .keyspec files that are used to generate the PSM xpcshell test certificates. (See e.g. bug 1189427 comment 2).
(Assignee)

Comment 1

3 years ago
Slight modification: it may be a good idea to add comments to certspec files, but I don't think it makes as much sense for the keyspec files. Rather than using comments, specifying the default key should be explicit rather than implicit. That way, the process is the same no matter what specification is being used: a) read the keyspec file, b) read pycert.py, c) ???, d) profit.
Summary: add comments to certspec and keyspec files where appropriate → pykey.py: make key specification explicit in all cases (rather than implicit)
(Assignee)

Comment 2

3 years ago
Created attachment 8644646 [details]
MozReview Request: bug 1190532 - change default key specification from implicit to explicit in pycert.py

bug 1190532 - change default key specification from implicit to explicit in pycert.py

Previously using an empty string would result in pycert.py returning the
default shared RSA key. This resulted in empty keyspec files being added
to the tree, which was confusing. This should end the confusion by making
the key specification process explicit rather than implicit.
Attachment #8644646 - Flags: review?(cykesiopka.bmo)
(Assignee)

Updated

3 years ago
QA Contact: dkeeler
(Assignee)

Comment 3

3 years ago
Ugh I always do that wrong.
Assignee: nobody → dkeeler
QA Contact: dkeeler

Updated

3 years ago
Attachment #8644646 - Flags: review?(cykesiopka.bmo) → review+

Comment 4

3 years ago
Comment on attachment 8644646 [details]
MozReview Request: bug 1190532 - change default key specification from implicit to explicit in pycert.py

https://reviewboard.mozilla.org/r/15281/#review13721

Profit sounds nice.
https://hg.mozilla.org/mozilla-central/rev/a7d1fa2cb596
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.