1190536 - 'Pin' button and 'Pin Page' title are not picking translations + misleading l10n note

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Théo Chevalier]

Attachment: Custom build with up-to-date French translations

Bug 1168948 introduced a new panel to Pin a webpage.

Code added here https://github.com/mozilla-b2g/gaia/pull/31146/files#diff-a5276edd04276b3b632b61ba37482b00R127

On the 3 strings added above, 'Pin' and 'Pin Page' are not picking translations from system.properties file. See attached screenshot with an up-to-date French locale (i.e, with translations for pinning.pin and pinning.pin-page). Only 'From' is properly translated, you should be able to reproduce the issue with pseudo-locales.

This is also the opportunity to fix the localization note which seems wrong:

https://github.com/mozilla-b2g/gaia/pull/31146/files#diff-81fe86f3f20787d354c9275a837572b9R613

># LOCALIZATION NOTE (pinning.pin, pinning.pin-page): These strings are used as
># button labels. "Pin" indicates the action to pin a website.

I suggest:

># LOCALIZATION NOTE (pinning.pin): This string is used as
># button label. "Pin" indicates the action to pin a website.
>pinning.pin=Pin
># LOCALIZATION NOTE (pinning.pin-page): This string is used as
># panel title. "Pin" indicates the action to pin a website.
>pinning.pin-page=Pin Page

Comment 1

[Francesco Lodolo [:flod]]

The localization comment was all mine, I completely missed that "Pin Page" was the title (also wasn't able to see the window on the phone) :-\

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1190536-pin-l10n > mozilla-b2g:master

Comment 3

[Alberto Pastor [:albertopq]]

Comment on attachment 8643658 [details] [review]
[gaia] albertopq:1190536-pin-l10n > mozilla-b2g:master

Could you please confirm everything looks good now? Thanks!

Comment 4

[Théo Chevalier]

Comment on attachment 8643658 [details] [review]
[gaia] albertopq:1190536-pin-l10n > mozilla-b2g:master

Left a couple nits in the PR but tested on a Flame, I can get the panel fully translated, thanks Alberto!

Comment 5

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/4ede0c6bf5fb0c2896d5393032b395999a154619