1190548 - [Settings] Tapping Edge Swipe Navigation toggle is inconsistent.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Nicholas Nelson [:NicholasN]]

Attachment: logcat_navigation.txt

Description:
In Settings > Navigation, the Edge Swipe Navigation toggle is difficult to consistently trigger. Other toggles (such as the lock orientation switch in Display) can be switched with every tap, but the Edge Swap Naviation toggle seems to work about 1/3 taps.


Repro Steps:
1) Update a Flame to 20150803030210
2) Go to Settings > Navigation.
3) Tap the Edge Swipe Navigation toggle.


Actual:
Toggling is inconsistent.


Expected:
Toggle works for every tap.


Notes:

Environmental Variables:
Device: Flame 2.5
Build ID: 20150803030210
Gaia: 2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gecko: 32712cd01159
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0


Repro frequency: 4/5
See attached: video clip, logcat

Comment 1

[Nicholas Nelson [:NicholasN]]

Issue reproduces on Flame 2.2, but not Flame 2.1.

Flame 2.2

Actual Result:

Tapping Edge Swipe Navigation toggle does not trigger with every tap, but it seems to perform slightly better than 2.5.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150803032504
Gaia: f8b119ac30e97df991c97682ac4d4f9ca22e1793
Gecko: 429b9d2d4566
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Flame 2.1

Actual Result:

Tapping Edge Swipe Navigation toggle works nearly every time.

Environmental Variables:
Device: Flame 2.1
BuildID: 20150724001207
Gaia: 9dba58d18006e921546cec62c76074ce81e16518
Gecko: 41e10c6740be
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 34.0 (2.1) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Nominating this functional performance issue for poor UX.

It may be taking a while to be ready again, other areas of settings we grey out the button in the waiting state.  NI on UX to review.

Window would be difficult here.

Comment 3

[[e-mail]]

@kevin I saw the same issue which looks like gaia-switch handles switch with `title only` list well, but does not count `title with description` list area into a tap-able area. So user tap on description area will not trigger the switch.

If we apply bug 1190713 more switches into settings, this issue will be amplified. Could you help take a look on this?

Comment 4

[Kevin Grandon :kgrandon]

Thanks for filing, it seems that it does not play well when there's an explanation attribute that follows the label. Will take a look.

Comment 5

[Kevin Grandon :kgrandon]

We know the problem, don't need UX involvement here.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1190548_gaia_switch_explanation > mozilla-b2g:master

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8645247 [details] [review]
[gaia] KevinGrandon:bug_1190548_gaia_switch_explanation > mozilla-b2g:master

Arhtur - could you give this a review?

I think that adding a details child to the gaia-switch is a nice way to solve this. Please take a look and let me know what you think. Thanks!

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8645247 [details] [review]
[gaia] KevinGrandon:bug_1190548_gaia_switch_explanation > mozilla-b2g:master

Oops, I meant to ask Fred here :) Thanks!

Comment 9

[[e-mail]]

Comment on attachment 8645247 [details] [review]
[gaia] KevinGrandon:bug_1190548_gaia_switch_explanation > mozilla-b2g:master

test on device and looks well, thanks!

Comment 10

[Kevin Grandon :kgrandon]

Thanks for the review!

In master: https://github.com/mozilla-b2g/gaia/commit/9f01d131450da44e660e3ccdfd1ac0bda4ec6172

Comment 11

[Martin Shuman [:Marty]]

This issue is verified fixed on the latest Spark 2.5, Flame 2.5 and 2.2 builds.
Tapping Edge Swipe Navigation toggle works every time.

Environmental Variables:
Device: Flame 2.5
BuildID: 20150812030210
Gaia: c7875bbc8b32e7b95cc55c9690b03b140905d84d
Gecko: d4f3a8a75577e4af2914a4e899ca2e724f9715c4
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150812032504
Gaia: 102f1299e9eafe3760e1deb44d556b5c4f36b5af
Gecko: 9295034c0ee3
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0