1190601 - Should be able to edit comments made from editing a current attachment

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[David Lawrence [:dkl]]

Related to request from bug 1190501. I was unable to edit the comments content as it was a comment type == 6 and not 0 or 5 like the extension template looks for. I do not see a reason we cannot edit 6 as well.

Patch coming

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 1190601_1.patch

Comment 2

[:glob ✱]

Comment on attachment 8642669 [details] [diff] [review]
1190601_1.patch

Review of attachment 8642669 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, with fix-on-commit

::: extensions/EditComments/template/en/default/hook/bug/comments-a_comment-end.html.tmpl
@@ +8,4 @@
>  
>  [% IF Param('edit_comments_group')
>     && user.in_group(Param('edit_comments_group'))
> +   && (comment.type == 0 || comment.type == 5 || comment.type == 6)

change these to use the CMT_* constants instead of integers.
we should also allow editing of CMT_DUPE_OF

Comment 3

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   0e478b8..9465a77  master -> master