1190602 - Formatting of 'Licenses' could use some clean up.

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Robin Andersen [:tecgirl]]

'FIREFOX FOR IOS' should be 'Firefox for iOS' 

"Licenses".  Let's find a way to break them up and/or consolidate, endless scroll is endless. Possibility: accordion navigation to collapse individual licenses.

Comment 1

[Richard Newman [:rnewman]]

Doesn't need to track v1, but this can be done in parallel with other work and should be on our radar.

Comment 2

[Bryan Munar (:bkmunar)]

Doesn't seem too bad(?), will work on once tracking bug to bug killer ratio is 1:1

Comment 3

[Bryan Munar (:bkmunar)]

jk that makes no sense, that means we have like 30 iOS peepz; ignore my comments after 4 pm

Comment 4

[Tummala Dhanvi [:c0mrad3][UTC+5.30]]

I would like to work on this bug can

Some pointers would be good for me to carry on

Comment 5

[Tummala Dhanvi [:c0mrad3][UTC+5.30]]

Attachment: Pull request

Hope this bug is fixed :)

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Tummala, we are not landing this bug for v1.0. Robin suggested some bigger changes to make it easier to navigate the licenses. That may also result in some native (Swift) work. Are you interested in that?

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8646402 [details] [review]
Pull request

Removing myself from review. Will pick this up post v1.

Comment 8

[Tummala Dhanvi [:c0mrad3][UTC+5.30]]

Well Stefan I am currently not into Swift, may be after learning few things I will give it a shot :) 

thanks for the heads up any way, It's better to make this bug not valid or something like that

Comment 9

[Robin Andersen [:tecgirl]]

Reopening, this bug is neither reviewed or resolved.

Comment 10

[Robin Andersen [:tecgirl]]

Additionally, the CSS could use some love. :c0mrad3, please feel free to ping me for this.

Comment 11

[Tummala Dhanvi [:c0mrad3][UTC+5.30]]

Well as I stated in the IRC I will work on this one but I need some time and little help 

which tecgirl is willing to provide me :)

Comment 12

[Tummala Dhanvi [:c0mrad3][UTC+5.30]]

(In reply to Robin Andersen [:tecgirl] from comment #10)
> Additionally, the CSS could use some love. :c0mrad3, please feel free to
> ping me for this.

hey @Robin Andersen can you please give me the links that you have told me to look at in the irc to fix this bug 

ie.. to make this licence more beautiful ? 

I forgot the link and not sure of the logs too

Comment 13

[Tummala Dhanvi [:c0mrad3][UTC+5.30]]

The file has been moved to https://github.com/mozilla/firefox-ios/blob/master/Client/Assets/About/Licenses.html 

and the link that I have asked was that https://jqueryui.com/accordion/

Comment 14

[Tummala Dhanvi [:c0mrad3][UTC+5.30]]

I need more time to fix this bug, hope it's okay

Comment 15

[Robin Andersen [:tecgirl]]

(In reply to Tummala Dhanvi [:c0mrad3][UTC+5.30] from comment #14)
> I need more time to fix this bug, hope it's okay

Checking in, how's this coming along?

Comment 16

[Tummala Dhanvi [:c0mrad3][UTC+5.30]]

I am learning things from this awesome website http://www.freecodecamp.com/dhanvi and codecadamy https://www.codecademy.com/dhanvicse I will fix this once I am comfortable with jquery 

If some one else want to work on this, please assign this bug to them

Hope this is okay

Comment 17

[Robin Andersen [:tecgirl]]

That's fine. I will let you know that the jQ example was just an example of how to implement an accordion, but isn't necessarily the best way. See if you can do it in just CSS rather than relying on javascript.

Comment 18

[Joel Miller]

Attachment: Screen Shot 2016-09-30 at 2.08.48 PM.png

Hi. I have a CSS-only solve for the accordion behavior (see screenshot). It's WIP but wanted to get input on whether the current plain styling will suffice, or if we want to jazz it up a bit.

Comment 19

[Robin Andersen [:tecgirl]]

(In reply to Joel Miller from comment #18)
> Created attachment 8796724 [details]
> Screen Shot 2016-09-30 at 2.08.48 PM.png
> 
> Hi. I have a CSS-only solve for the accordion behavior (see screenshot).
> It's WIP but wanted to get input on whether the current plain styling will
> suffice, or if we want to jazz it up a bit.

Looks good! 

I can make the style changes to jazz it up :) 

Thanks, Joel!

Comment 20

[Joel Miller]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2211

PR attached. FYI, method used for the accordion adapted from here: http://tympanus.net/codrops/2012/02/21/accordion-with-css3/

Comment 21

[Robin Andersen [:tecgirl]]

Comment on attachment 8807039 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2211

Looks and works well! I'll work on making the styles a bit better.

Comment 22

[Avedis Zeitounilian]

I'm a student at Seneca college learning open source, and I was hoping to work on this bug for my course.  If no one else is currently working on it, I'd like to give it a try.

Comment 23

[Aaron Train [:aaronmt]]

Feel free to extend on the older pull-request (might need rebasing and or a list of things to change from Robin)

Comment 24

[Yevhen]

Attachment: the PR

Comment 25

[Yevhen]

I took a look at Joel's PR (https://github.com/mozilla-mobile/firefox-ios/pull/2211) changes. 

Even though, I'd suggest some formatting to text (adjust font sizes mostly), the change itself looks good. It implements an accordion UX, which looks better than an "endless scroll" UX to me.