1190608 - Clean up style in nsXULElement.cpp

Status: RESOLVED FIXED

(Core :: XUL, defect)

Comment 1

[Andrew McCreight [:mccr8]]

This is just a few specific things that annoy me.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Delete trailing whitespace in nsXULElement.cpp and nsXULPrototypeCache.cpp.

Also, change the mode line for nsXULElement.cpp to match reality, which is 4 space indentation.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Tuck elses in nsXULElement.cpp.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Remove some infallible new checks in nsXULElement.cpp.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Brace a few ifs in nsXULElement.cpp.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: part 5 - Sink the declaration of i in nsXULElement.cpp.

Comment 7

[Andrew McCreight [:mccr8]]

Is it okay if I get poiru to review this, assuming he'd be okay with it?

Comment 8

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Tuck elses in nsXULElement.cpp.

Minor rebasing. So minor I'm not sure what changed, but git complained.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Sure (to comment 1)

I'd love to see nsXULElement.cpp to start using 2 spaces though. Perhaps that can be fixed in a different bug.

Comment 10

[Andrew McCreight [:mccr8]]

(In reply to Olli Pettay [:smaug] from comment #9)
> I'd love to see nsXULElement.cpp to start using 2 spaces though. Perhaps
> that can be fixed in a different bug.

Yeah. I started doing that by hand (well, using emacs auto-indenting) but it seemed too tedious and error prone. It would be better done with some kind of actual formatter like poiru has been using.

Comment 11

[Andrew McCreight [:mccr8]]

Comment on attachment 8642818 [details] [diff] [review]
part 1 - Delete trailing whitespace in nsXULElement.cpp and nsXULPrototypeCache.cpp.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc1270fc3343

Comment 12

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Brace a few ifs in nsXULElement.cpp.

Rebased again. Hopefully that's the last of it.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3ba882cb9c
https://hg.mozilla.org/integration/mozilla-inbound/rev/99a5c0692c09
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1579da7f21e
https://hg.mozilla.org/integration/mozilla-inbound/rev/93bc28d6facd
https://hg.mozilla.org/integration/mozilla-inbound/rev/de90e543e4f2

Comment 14

[Andrew McCreight [:mccr8]]

Thanks for the fast reviews.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f3ba882cb9c
https://hg.mozilla.org/mozilla-central/rev/99a5c0692c09
https://hg.mozilla.org/mozilla-central/rev/f1579da7f21e
https://hg.mozilla.org/mozilla-central/rev/93bc28d6facd
https://hg.mozilla.org/mozilla-central/rev/de90e543e4f2