Clean up style in nsXULElement.cpp

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(5 attachments, 2 obsolete attachments)

Assignee

Description

4 years ago
No description provided.
Assignee

Comment 1

4 years ago
This is just a few specific things that annoy me.
Assignee

Comment 2

4 years ago
Also, change the mode line for nsXULElement.cpp to match reality, which is 4 space indentation.
Assignee

Comment 7

4 years ago
Is it okay if I get poiru to review this, assuming he'd be okay with it?
Flags: needinfo?(bugs)
Assignee

Comment 8

4 years ago
Minor rebasing. So minor I'm not sure what changed, but git complained.
Attachment #8642819 - Attachment is obsolete: true
Sure (to comment 1)

I'd love to see nsXULElement.cpp to start using 2 spaces though. Perhaps that can be fixed in a different bug.
Flags: needinfo?(bugs)
Assignee

Comment 10

4 years ago
(In reply to Olli Pettay [:smaug] from comment #9)
> I'd love to see nsXULElement.cpp to start using 2 spaces though. Perhaps
> that can be fixed in a different bug.

Yeah. I started doing that by hand (well, using emacs auto-indenting) but it seemed too tedious and error prone. It would be better done with some kind of actual formatter like poiru has been using.
Assignee

Comment 11

4 years ago
Comment on attachment 8642818 [details] [diff] [review]
part 1 - Delete trailing whitespace in nsXULElement.cpp and nsXULPrototypeCache.cpp.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc1270fc3343
Attachment #8642818 - Flags: review?(birunthan)
Assignee

Updated

4 years ago
Attachment #8642820 - Flags: review?(birunthan)
Assignee

Updated

4 years ago
Attachment #8642821 - Flags: review?(birunthan)
Assignee

Updated

4 years ago
Attachment #8642822 - Flags: review?(birunthan)
Assignee

Updated

4 years ago
Attachment #8643063 - Flags: review?(birunthan)
Assignee

Comment 12

4 years ago
Rebased again. Hopefully that's the last of it.
Attachment #8642821 - Attachment is obsolete: true
Attachment #8642821 - Flags: review?(birunthan)
Attachment #8643186 - Flags: review?(birunthan)
Attachment #8642818 - Flags: review?(birunthan) → review+
Attachment #8642820 - Flags: review?(birunthan) → review+
Attachment #8642822 - Flags: review?(birunthan) → review+
Attachment #8643186 - Flags: review?(birunthan) → review+
Attachment #8643063 - Flags: review?(birunthan) → review+
Assignee

Comment 14

4 years ago
Thanks for the fast reviews.
You need to log in before you can comment on or make changes to this bug.