Closed
Bug 1190672
Opened 10 years ago
Closed 10 years ago
Fix brain-dead use of AutoReleasePromiseWorkerProxy
Categories
(Core :: DOM: Push Subscriptions, defect)
Core
DOM: Push Subscriptions
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file)
MozReview Request: Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r?catalinb
40 bytes,
text/x-review-board-request
|
catalinb
:
review+
|
Details |
In hindsight, my patch at Bug 1184574 was obviously wrong in the implementation and use of AutoReleasePromiseWorkerProxy. the class constructor asserts that a certain thread owns a lock, but it is being used in runnable destructors which can run on either the sender or receiver thread. I'll file a fix here.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r?catalinb
Attachment #8642858 -
Flags: review?(catalin.badea392)
Updated•10 years ago
|
Attachment #8642858 -
Flags: review?(catalin.badea392) → review+
Comment 3•10 years ago
|
||
Comment on attachment 8642858 [details]
MozReview Request: Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r?catalinb
https://reviewboard.mozilla.org/r/14971/#review13471
lgtm, but maybe AutoReleasePromiseWorkerProxy doesn't need to be a class since it's only used as a function that dispatches the control runnable.
Assignee | ||
Comment 4•10 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/7ffb30e0ec45dcebebdb324640685060c9035bae
changeset: 7ffb30e0ec45dcebebdb324640685060c9035bae
user: Nikhil Marathe <nsm.nikhil@gmail.com>
date: Mon Aug 03 21:47:16 2015 -0700
description:
Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r=catalinb
Comment 5•10 years ago
|
||
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•