Fix brain-dead use of AutoReleasePromiseWorkerProxy

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nsm, Assigned: nsm)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

In hindsight, my patch at Bug 1184574 was obviously wrong in the implementation and use of AutoReleasePromiseWorkerProxy. the class constructor asserts that a certain thread owns a lock, but it is being used in runnable destructors which can run on either the sender or receiver thread. I'll file a fix here.
Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r?catalinb
Attachment #8642858 - Flags: review?(catalin.badea392)
Attachment #8642858 - Flags: review?(catalin.badea392) → review+
Comment on attachment 8642858 [details]
MozReview Request: Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r?catalinb

https://reviewboard.mozilla.org/r/14971/#review13471

lgtm, but maybe AutoReleasePromiseWorkerProxy doesn't need to be a class since it's only used as a function that dispatches the control runnable.
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7ffb30e0ec45dcebebdb324640685060c9035bae
changeset:  7ffb30e0ec45dcebebdb324640685060c9035bae
user:       Nikhil Marathe <nsm.nikhil@gmail.com>
date:       Mon Aug 03 21:47:16 2015 -0700
description:
Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r=catalinb
https://hg.mozilla.org/mozilla-central/rev/7ffb30e0ec45
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.