1190672 - Fix brain-dead use of AutoReleasePromiseWorkerProxy

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

In hindsight, my patch at Bug 1184574 was obviously wrong in the implementation and use of AutoReleasePromiseWorkerProxy. the class constructor asserts that a certain thread owns a lock, but it is being used in runnable destructors which can run on either the sender or receiver thread. I'll file a fix here.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f57b83d52975

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r?catalinb

Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r?catalinb

Comment 3

[Cătălin Badea (:catalinb)]

Comment on attachment 8642858 [details]
MozReview Request: Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r?catalinb

https://reviewboard.mozilla.org/r/14971/#review13471

lgtm, but maybe AutoReleasePromiseWorkerProxy doesn't need to be a class since it's only used as a function that dispatches the control runnable.

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7ffb30e0ec45dcebebdb324640685060c9035bae
changeset:  7ffb30e0ec45dcebebdb324640685060c9035bae
user:       Nikhil Marathe <[e-mail]>
date:       Mon Aug 03 21:47:16 2015 -0700
description:
Bug 1190672 - Fix use of AutoReleasePromiseWorkerProxy in PushManager. r=catalinb

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7ffb30e0ec45