1190683 - "start communicating" is odd phrasing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Morpheus Chen [:morpheus] UX]

Attachment: 2015-08-04-10-59-58.png

"The Messaging app's "Start communicating" call to action trips me up because it is almost actionable, but not quite, therefore it might be a bad CTA. "communicating" is an abstract concept ("expressing ideas"), not a concrete action.

"Start by writing a message" or something similar would be a concrete thing I can achieve with this app, and seems to be a better CTA."  - Fred Wenzel 

The Phone app has the same issue, so filing this bug for consistency.

Comment 1

[Morpheus Chen [:morpheus] UX]

Attachment: [Dialer] Welcome message v1.0.pdf

Please find the attachment for the updated welcome message.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

Comment 3

[Alexey Yakimov]

Comment on attachment 8691253 [details] [review]
[gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

Gabriele, please review the changes or ask someone else to proceed with review. Thanks in advance.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8691253 [details] [review]
[gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

I think that you should change the l10n-id if you're changing the string so that the people working on the translations can spot the changes. I'm also not sure if "Start a conversation now" is appropriate here since this is the call log, not the messaging app. Zibi can you give us your feedback here?

Comment 5

[Alexey Yakimov]

As per the PDF file attached by Morpheus the sentense should be "Start a conversation now". 

In regards to new l10n-id, we checked that this string is not used anywhere except this screen, so no other functionality is affected. If it is necessary to change l10n-id anyway, it is fine and we will make the required changes. Please advice how to proceed here.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8691253 [details] [review]
[gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

yup, update the ID please.

Comment 7

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8691253 [details] [review]
[gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

OK, thanks for the clarification Zibi. Alexey please also change the l10n id and ask for review again, thanks.

Comment 8

[Alexey Yakimov]

We noticed that there is a Chinese version of such string avilable here (in test folder): gaia/build/test/resources/locales/zh-CN/apps/communications/dialer/dialer.properties

Please advise whether we should keep this file as it is now or should we request someone to provide a traslation?

Comment 9

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Alexey Yakimov from comment #8)
> We noticed that there is a Chinese version of such string avilable here (in
> test folder):
> gaia/build/test/resources/locales/zh-CN/apps/communications/dialer/dialer.
> properties
> 
> Please advise whether we should keep this file as it is now or should we
> request someone to provide a traslation?

I have no idea where that's coming from; I was under the impression that we had removed all non-English localizations from the sources. Zibi, sorry to bother you again but do you happen to know anything about those files?

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Please, keep the file as is. It's just a fixture used for build tests.

Comment 11

[Alexey Yakimov]

Comment on attachment 8691253 [details] [review]
[gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

The commit has been updated with new localization id, please review.

Comment 12

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8691253 [details] [review]
[gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

This works but it's a bit excessive; please only change the l10n id. You don't need to change the element id in index.html, that can still be called no-result-msg2 so that you won't have to change the JS code and the test too. Last but not least remove the no-logs-msg-2 l10n id since we won't be using it anymore.

Comment 13

[Alexey Yakimov]

Comment on attachment 8691253 [details] [review]
[gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

The requested changes have been made, hope it is fine now, please review.

Comment 14

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8691253 [details] [review]
[gaia] ruoslepov:bug-1190683-start-communicating-is-odd-phrasing > mozilla-b2g:master

Excellent, thanks!

Comment 15

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/1753636c36d782663773fd8376c9af769bf83045

Comment 16

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame master and Aries KK master by the STR in comment 0.

Actual results: It shows "Start a conversation now" in call log.
See attachment: verified_Flame_master_calllog.png
Reproduce rate: 0/10


Device: Flame master_512mb (Pass)
Build ID               20151206150208
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151206.184313
Firmware Date          Sun Dec  6 18:43:25 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151206002630
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151205.234548
Firmware Date          Sat Dec  5 23:45:56 UTC 2015
Bootloader             s1

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_master_calllog.png