Closed
Bug 1190713
Opened 9 years ago
Closed 9 years ago
[Settings] Port a few gaia-switches to use web components
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
No description provided.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8643069 [details] [review] [gaia] KevinGrandon:bug_1190713_settings_gaia_switch_progress > mozilla-b2g:master Hey Fred - wondering if you could give this a review. I'm trying to not make this patch too huge, so maybe one or two more parts to follow to port the remaining switches. Thanks!
Attachment #8643069 -
Flags: review?(gasolin)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8643069 [details] [review] [gaia] KevinGrandon:bug_1190713_settings_gaia_switch_progress > mozilla-b2g:master Thanks for keeping update gaia-switch to settings! Please address the comments on github and make sure the search panel looks fine before landing. It will be better to land this issue after fixing bug 1190548 (description area not tappable in switch) so this related issue wont get noticed by more foxfooding people.
Attachment #8643069 -
Flags: review?(gasolin) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Addressed nits and this is working much better. Thanks! In master: https://github.com/mozilla-b2g/gaia/commit/f238f27860f734db255f0184b4b31015effea4f2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•9 years ago
|
||
Still a bit more work to do here.
Summary: [Settings] Port remaining gaia-switches to use web components → [Settings] Port a few gaia-switches to use web components
You need to log in
before you can comment on or make changes to this bug.
Description
•