1190716 - Update Hello FTU for Firefox >= 40 to interactive version

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

Much of the Hello FTU code was refactored for Firefox 40 in Bug 1178217. We now need to update this code again to include the door-hangers and the final call connection step.

Comment 1

[Alex Gibson [:agibson]]

I have this mostly working now using the refactored code, just need to update and write new tests. 

Fabio, there was mention of a new string needed - do we have this yet? Thanks

Comment 2

[Fabio Rios [:frios]]

(In reply to Alex Gibson [:agibson] from comment #1)
> I have this mostly working now using the refactored code, just need to
> update and write new tests. 
> 
> Fabio, there was mention of a new string needed - do we have this yet? Thanks

Yes. 

Current line: Open a video conversation with a single click, then invite a friend to join.

New line: Click the blue button to start a video conversation, then invite a friend to join.

Comment 3

[Fabio Rios [:frios]]

Attachment: hello-bubble.JPG

I should add that the line replaces highlighted text only. You can leave the title [Welcome to Hello] as is.

Thanks Alex

Comment 4

[Alex Gibson [:agibson]]

Hi Fabio,

I think we need to change another string:

'Once your friend clicks the link, the Hello icon will change to blue, letting you know they’re there.'

This isn't actually correct, as the Hello icon turns blue as soon as the user opens a room (see Bug 1176684).

For the static version we are currently using for FF 40, we changed:

'The Hello icon will change to blue once they’ve joined'

to:

'You will receive a notification once they’ve joined'

We may need something similar here for the interactive version?

Comment 5

[Fabio Rios [:frios]]

Attachment: wrong-instruction.JPG

Good flag. Yes, let's replace that too.

Proposed new text

Current: 

No need to wait around
Once your friend clicks the link, the Hello icon will change to blue, letting you know they're there.

Proposed:

No need to wait around
Continue browsing from any tab and you will be notified once they’ve joined.

@romain: good with you?

Comment 6

[Romain Testard [:RT]]

(In reply to Fabio Rios [:frios] from comment #5)
> Created attachment 8647168 [details]
> wrong-instruction.JPG
> 
> Good flag. Yes, let's replace that too.
> 
> Proposed new text
> 
> Current: 
> 
> No need to wait around
> Once your friend clicks the link, the Hello icon will change to blue,
> letting you know they're there.
> 
> Proposed:
> 
> No need to wait around
> Continue browsing from any tab and you will be notified once they’ve joined.
> 
> @romain: good with you?

NIing Matej since he usually makes the copy decisions on the project.

It just feels people won't know who's "they" and also only one person can join.

My proposal:
No need to wait around
Continue browsing from any tab and you will be notified once your friend joins.

Comment 7

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 8

[Matej Novak [:matej]]

(In reply to Romain Testard [:RT] from comment #6)
> (In reply to Fabio Rios [:frios] from comment #5)
> > Created attachment 8647168 [details]
> > wrong-instruction.JPG
> > 
> > Good flag. Yes, let's replace that too.
> > 
> > Proposed new text
> > 
> > Current: 
> > 
> > No need to wait around
> > Once your friend clicks the link, the Hello icon will change to blue,
> > letting you know they're there.
> > 
> > Proposed:
> > 
> > No need to wait around
> > Continue browsing from any tab and you will be notified once they’ve joined.
> > 
> > @romain: good with you?
> 
> NIing Matej since he usually makes the copy decisions on the project.
> 
> It just feels people won't know who's "they" and also only one person can
> join.
> 
> My proposal:
> No need to wait around
> Continue browsing from any tab and you will be notified once your friend
> joins.

We could say "someone" instead of "your friend," but either way I'm good with this. Thanks.

Comment 9

[Fabio Rios [:frios]]

Updated:
No need to wait around
Continue browsing from any tab and you will be notified once someone joins.

Comment 10

[Alex Gibson [:agibson]]

Thanks all, I'll take these strings as final.

Comment 11

[Alex Gibson [:agibson]]

Holly, Fabio - I have filed two bugs I encountered while working on this bug. Sadly, I don't think either have simple solutions that we can use on the web side of things. 

I know there's already been a lot of talk about when is acceptable to ship for Firefox 40, but I wanted to make sure people are aware of these issues before we do so.

Comment 12

[Alex Gibson [:agibson]]

To be clear, the bugs I refer to in Comment 11 are Bug 1197562 and Bug 1197564.

Comment 13

[Alex Gibson [:agibson]]

Good news I found a work around for Bug 1197562, so I think it's only Bug 1197564 that still poses some question.

Comment 14

[Alex Gibson [:agibson]]

This change is now up on demo2:

Hello FTU Setup:
1.) Open about:config
2.) Set "loop.gettingStarted.url" to "https://www-demo2.allizom.org/%LOCALE%/firefox/%VERSION%/hello/start
3.) Add "https://www-demo2.allizom.org" to the comma-delimited preference "browser.uitour.testingOrigins". It won't exist by default.

To launch the FTU, open the Hello panel and click the gear icon. Then click on "Tour"

If all has been set correctly above, the demo2 FTU URL should then open and start the tour.

Comment 15

[Alex Gibson [:agibson]]

Gareth, when you have some free time could I please ask you give this a test on demo2 to make sure GA events seem ok? There is nothing new feature-wise, just some code-refactoring. But it would be good to double-check that things seem ok in GTM.

There are testing instructions in Comment 14. Any questions feel free to ping me in IRC and we can hop on Vidyo.

Comment 16

[Holly Habstritt Gaal [:Habber]]

As shown in Bug 1197564, given the addition of the "Let's talk about" area in the video panel, I would not show the tour in its current state. The info panel does not point to the area in the panel that it is talking about which is misleading and confusing for users. See Bug 1197564 for details and a possible solution.

Comment 17

[Alex Gibson [:agibson]]

Will wait for Bug 1197564 to be resolved before moving forward on this.

Comment 18

[Gareth Cull [:garethc]]

Thanks Alex. I can see all of the events coming through on demo2:
http://cl.ly/image/3t072x343006

Comment 19

[Alex Gibson [:agibson]]

This change has now been given an r+ in code review, and GA data has been verified as per Comment 18. All that's really blocking this from completing now is a resolution for Bug 1197564.

Comment 20

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Alex Gibson [:agibson] from comment #19)
> This change has now been given an r+ in code review, and GA data has been
> verified as per Comment 18. All that's really blocking this from completing
> now is a resolution for Bug 1197564.

Are the strings final for l10n now?

Comment 21

[Alex Gibson [:agibson]]

(In reply to Pascal Chevrel:pascalc from comment #20)
> (In reply to Alex Gibson [:agibson] from comment #19)
> > This change has now been given an r+ in code review, and GA data has been
> > verified as per Comment 18. All that's really blocking this from completing
> > now is a resolution for Bug 1197564.
> 
> Are the strings final for l10n now?

Not quite - we're still waiting on a resolution for Bug 1197564. This may involve one more string, so best hold off for now.

Comment 22

[Fabio Rios [:frios]]

Confirmed copy with Matej, let's go with this:

Email, copy or share the link
Your friends can connect instantly.
They don't even need Firefox to join.(In reply to Alex Gibson [:agibson] from comment #11)
> Holly, Fabio - I have filed two bugs I encountered while working on this
> bug. Sadly, I don't think either have simple solutions that we can use on
> the web side of things. 
> 
> I know there's already been a lot of talk about when is acceptable to ship
> for Firefox 40, but I wanted to make sure people are aware of these issues
> before we do so.

Per bug  1197564

Proposing moving forward using the updated string to associate the speech bubble with the buttons despite the possible misalignment:

New copy:

Email, copy or share the link
Your friends can connect instantly.
They don't even need Firefox to join.

Old copy:

Share your link with a friend
They don't even need Firefox to join.
They just need to click the link.

Comment 23

[Alex Gibson [:agibson]]

Thanks, I will update the PR shortly and we can then expose the strings.

Comment 24

[Alex Gibson [:agibson]]

(In reply to Pascal Chevrel:pascalc from comment #20)
> (In reply to Alex Gibson [:agibson] from comment #19)
> > This change has now been given an r+ in code review, and GA data has been
> > verified as per Comment 18. All that's really blocking this from completing
> > now is a resolution for Bug 1197564.
> 
> Are the strings final for l10n now?

Pascal - strings for this one are now final and the PR has been updated. Thanks

https://github.com/mozilla/bedrock/pull/3198

Comment 25

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/11aa1a1380d09f2cbd36890703c2bfc9b1640ba7
[fix bug 1190716] Update Hello FTU for Firefox 40 to interactive version

https://github.com/mozilla/bedrock/commit/6e423c6e86f53634a5573ea3ee81b9685670954a
Merge pull request #3198 from alexgibson/bug-1190716-update-hello-ftu-interactive

[fix bug 1190716] Update Hello FTU for Firefox 40 to interactive version