Closed Bug 1190759 Opened 5 years ago Closed 4 years ago

Intermittent e10s browser_registerProtocolHandler_notification.js | 100 -

Categories

(Firefox :: File Handling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
e10s + ---
firefox42 --- affected
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: cbook, Assigned: u459114)

References

(Blocks 1 open bug, )

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

https://treeherder.mozilla.org/logviewer.html#?job_id=12459703&repo=mozilla-inbound

 23:55:07 INFO - 483 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_registerProtocolHandler_notification.js | 100 -
The first instance of this e10s-only failure was shortly after bug 1190245 landed. Possibly related?
tracking-e10s: --- → ?
Component: General → File Handling
Flags: needinfo?(kchen)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #16)
> The first instance of this e10s-only failure was shortly after bug 1190245
> landed. Possibly related?

My try run with bug 1190245 backed out in comment 19 didn't trigger any failure so it looks like related. How the butterfly effect works is still a mystery. I'll take a look.
In fact my try run mochitest-e10s-browser-chrome-1 didn't run the test. Why the tests is sometimes in mochitest-e10s-browser-chrome-1 sometimes in mochitest-e10s-browser-chrome-2 or mochitest-e10s-browser-chrome-3...
hit this condition
https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/head.js#102
I am trying to extend "tries" from 30 to 100
Try result, retry 50 times in waitForCondition
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ad2de550c24&selectedJob=15065188
100 times, just in case we still get failure by changing to 50 times.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a1ffe33ff8c&selectedJob=15065172
What I did in this patch
1. Add retry parameter to waitForCondition, so the caller can customize retry times.
2. browser_registerProtocolHandler_notification::test function will retry 50 times.(Before this change, only retry 30 times)
3. Better error message.
Before extend retry times, failure rate is around 1/10 ~ 1/20.

Extend retry time to 100(10 seconds) - 0/52(no failure).
Extend retry times 60(6 seconds) - 0/56
Extend retry times 50(5 seconds) - 1/50
Attachment #8704045 - Attachment is obsolete: true
Summary: Intermittent browser_registerProtocolHandler_notification.js | 100 - → Intermittent e10s browser_registerProtocolHandler_notification.js | 100 -
Any news here? This is still one of the most frequent e10s test failures in CI.
Flags: needinfo?(cku)
Attachment #8725072 - Flags: review?(dougt)
Attachment #8704154 - Attachment is obsolete: true
Flags: needinfo?(cku)
I didn't see a failure after change to 100 retries.
Assignee: nobody → cku
blake, can you review or find reviewer?
Flags: needinfo?(mrbkap)
Comment on attachment 8725072 [details]
MozReview Request: Bug 1190759 - Increase waitForCondition retry times in registerProtocolHandler notification test.

https://reviewboard.mozilla.org/r/37325/#review34435

Sure, why not.
Flags: needinfo?(mrbkap)
https://hg.mozilla.org/mozilla-central/rev/bde14028c597
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Attachment #8725072 - Flags: review?(dougt)
You need to log in before you can comment on or make changes to this bug.