1190769 - about:newtab should fall back to Tahoma as a font on Windows XP

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Screen Shot 2015-08-04 at 11.09.37.png

The tiles on about:newtab try to use Segoe UI as the font even on Windows XP (where this font is not available). As a result, the system falls back to a really crappy version of Times.

We should add Tahoma as a fallback there (default UI font on XP).
Note that the gear menu on that same page already uses the correct fallback font.

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: add Tahoma as fallback font for newtab tiles

Added Tahoma as a fallback font in the Windows-specific CSS file.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8704155 [details] [diff] [review]
add Tahoma as fallback font for newtab tiles

This works, I guess, but it's still not quite the right way to approach fonts here.

Can you please try using something like this instead:

.newtab-title {
  font: message-box;
  font-size: 1em;
]

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: change font handling in .newtab-title

Alright! I needed to re-adjust line-height as well to restore the old appearance.
I used px values since everything in the newtab CSS uses px.

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8705636 [details] [diff] [review]
change font handling in .newtab-title

Switching reviewers since Dão has limited availability at the moment.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8705636 [details] [diff] [review]
change font handling in .newtab-title

Review of attachment 8705636 [details] [diff] [review]:
-----------------------------------------------------------------

This patch seems to be built on the other patch and so it doesn't apply. If you're using mq, use qfold to fold the two patches. If you're using evolve / "real commits", use something like:

hg histedit -r <previous-rev>

and then use "fold" or "roll" to combine the two commits.

::: browser/themes/windows/newtab/newTab.css
@@ +15,5 @@
>  
>  .newtab-title {
> +  font: message-box;
> +  font-size: 13px;
> +  line-height: 30px;

Both of these properties are already set in newTab.css:

https://dxr.mozilla.org/mozilla-central/rev/584870f1cbc5d060a57e147ce249f736956e2b62/browser/base/content/newtab/newTab.css#182-183

so please don't set them again.

Comment 6

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #5)
> ::: browser/themes/windows/newtab/newTab.css
> @@ +15,5 @@
> >  
> >  .newtab-title {
> > +  font: message-box;
> > +  font-size: 13px;
> > +  line-height: 30px;
> 
> Both of these properties are already set in newTab.css:
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> 584870f1cbc5d060a57e147ce249f736956e2b62/browser/base/content/newtab/newTab.
> css#182-183
> 
> so please don't set them again.

Oh, I guess because you're using font, this gets overridden, and message-box isn't a valid value for font-family. I agree with Dão that we shouldn't be using px to size the font and line-height. Considering it's already being done, I guess we can do it this way, but please file a followup bug to fix the new tab CSS to use em instead.

Comment 7

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: fix newtab typography on Windows XP

OK, that one should work now. I'll file the follow-up bug now...

Comment 8

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Follow-up: bug 1245851

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3b7757168119

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3b7757168119