1190795 - The layout switching button shows "en" instead of "En"

Status: RESOLVED DUPLICATE of bug 1192117

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Enable more than one keyboard layout
2. Show English keyboard
3. Disengage shift
4. Read the label shown on layout switch button.

Expected:

1. "en" is shown

Actual:

1. Should be "En".


Harly, you ui-review+'d the patch in bug 965211. Is this desired behavior or a valid bug?

Comment 1

[Harly Hsu[:harly]]

My bad, I didn't realise that the label for language will change when users tap on the shift key. This is not the intended design, "En" is just a language indicator and should not change when users tap the shift key.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This can be fixed by changing our DOM construction code to only emit upper-cased label on layout switch button.

Comment 3

[Roger Braun]

This problem is extending to other special keys like the Alt button, which will get lowercased, too. 

I fixed this by setting "text-transform: unset" for .switch-key and .page-switch-key. Do you think this is a good solution? Should I do a PR?

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Roger Braun from comment #3)
> This problem is extending to other special keys like the Alt button, which
> will get lowercased, too. 
> 
> I fixed this by setting "text-transform: unset" for .switch-key and
> .page-switch-key. Do you think this is a good solution? Should I do a PR?

Please do. Thank you for spending time investigating. 

I have to admit this is caused by my sloppy review of bug 965211. We should probably not be rely on CSS to do the transformation at first place -- upper-lower case pairs are not deterministic if you consider all languages. That said, after inspecting the Turkish keyboard (because of their infamous "İ" character), I don't see any visible problem.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Actually... I ended up fixing this bug in bug 1192117, right after I made the above comment. Let me set a feedback flag to you on my patch so you could verify that.


Thank you for investigating! I won't find the bug without your comment.