1190837 - MozSelfsupport.healthReportDataSubmissionEnabled does not work when turning off DRS / FHR

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P1)

Comment 1

[Georg Fritzsche [:gfritzsche]]

This actually works fine even with FHR disabled per pref (datareporting.healthreport.service.enabled), so we don't need to do anything here for shipping in 41.

However, we need to fix this when we actually remove the datareporting service and other FHR code on desktop.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Attachment: WIP

We could do something like this (i.e. just have a fallback for when DRS is not available) or just remove the Policy usage completely. I'm not sure offhand if removing would ever affect mobile though.

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: abouthealth-switch

As discussed, I've changed this a bit by moving the try-catch into the defineLazyGetter block.

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: abouthealth-switch

Updated the commit message.

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8656504 [details] [diff] [review]
abouthealth-switch

Review of attachment 8656504 [details] [diff] [review]:
-----------------------------------------------------------------

Please check it keeps working manually.

::: browser/components/selfsupport/SelfSupportService.js
@@ +12,4 @@
>  
> +const PREF_FHR_UPLOAD_ENABLED = "datareporting.healthreport.uploadEnabled";
> +
> +XPCOMUtils.defineLazyGetter(this, "policy", () => {

Let's make it |gPolicy|.

Comment 6

[Alessio Placitelli [:Dexter]]

Note: I've manually tested this by throwing an exception into the try-catch block inside the lazy getter (e.g. policy object not available). As expected, the health report status is fetched from the prefs.

Comment 7

[Alessio Placitelli [:Dexter]]

Attachment: abouthealth-switch

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd88e517731c

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d3d166232d2d

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d3d166232d2d

Comment 10

[Ada [:adalucinet]]

Verified fixed with latest 43.0a2 Developer Edition (from 2015-09-27), across platforms [1]. Based on the steps that :Dexter provided, I confirm that with DRS disabled, MozSelfSupport.healthReportDataSubmissionEnabled returns the same value as 'datareporting.healthreport.uploadEnabled' pref has.

[1] Windows 7 64-bit, Mac OS X 10.11 Beta and Ubuntu 14.04 32-bit