cache entries corrupted if size of metadata is zero

RESOLVED FIXED in mozilla0.9.9

Status

()

Core
Networking: Cache
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: gordon, Assigned: gordon)

Tracking

Trunk
mozilla0.9.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
nsCacheMetaData::UnflattenMetaData() returns an error when metadata size is
zero, causing the associated entry to be unusable.
(Assignee)

Comment 1

17 years ago
Created attachment 64899 [details] [diff] [review]
return NS_OK for size = 0.

Darin, I changed the patch to exit early on size==0 rather than change the
default return error to catch problems when the reported size doesn't match the
size implied by the data itself.

Comment 2

17 years ago
Comment on attachment 64899 [details] [diff] [review]
return NS_OK for size = 0.

sr=darin
Attachment #64899 - Flags: superreview+
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla0.9.8
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.8 → mozilla0.9.9
gordon: Is it possible to check this into the 0.9.8 branch? I'm attempting to
checkin my patch in to the branch this week and I need yours to maintain proper
functionality. Thanks,
(Assignee)

Comment 4

17 years ago
I don't see bug 35340 listed as an important bug for 0.9.8.  Are you sure you're
going to get drivers approval?  That's all I need to check this in.  I would
rather check it in before they branch.  Are you ready to check in your patch?
I'm working to get reviews right now for bug 35340. I'm also generating
momentum, so this  will be accepted into 0.9.8 branch.
gordon: I just now had a word with jud. 35340 will not be going into the 0.9.8
branch. So, it is OK if you check this in the trunk for 0.9.9. sorry about the
confusion. 
(Assignee)

Comment 7

17 years ago
patch checked in. Marking FIXED.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.