Provide a link to browse the entire code tree at a given changeset in a review queue

RESOLVED FIXED

Status

MozReview
General
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kats, Assigned: dminor)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

My use case:
In https://reviewboard.mozilla.org/r/11623/ the changeset adds a new file (test_wheel_transactions.html) which I would like to load in a browser. Since MozReview has the changeset in Mercurial I should in theory be able to do something like go to https://hg.mozilla.org/some-mozreview-repo/raw-file/<rev>/.../test_wheel_transactions.html and view the page in the browser via hgweb. So having a link from the review request to the tree at https://hg.mozilla.org/some-mozreview-repo/<rev> would be really useful.

In general it might also be useful to see the state of other files in the tree at a particular changeset in a multi-patch review queue.

Comment 1

2 years ago
This is a good feature request and should be easy enough to add.

Updated

2 years ago
Priority: -- → P2
(Assignee)

Updated

2 years ago
Assignee: nobody → dminor
(Assignee)

Comment 2

2 years ago
I think it would make sense to fix bug 1123139 before we add even more stuff to the "description" field.
Depends on: 1123139
(Assignee)

Comment 3

2 years ago
Created attachment 8656577 [details]
MozReview Request: mozreview: Provide a link to browse the entire code tree at a given commit (bug 1190895) r?mcote

mozreview: Provide a link to browse the entire code tree at a given commit (bug 1190895) r?mcote

This adds a link to the commits table to the mercurial server allowing the user
to view the commit there.
Attachment #8656577 - Flags: review?(mcote)

Comment 4

2 years ago
Comment on attachment 8656577 [details]
MozReview Request: mozreview: Provide a link to browse the entire code tree at a given commit (bug 1190895) r?mcote

https://reviewboard.mozilla.org/r/18219/#review16705
Attachment #8656577 - Flags: review?(mcote) → review+
(Assignee)

Comment 5

2 years ago
Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/9fd196f65914
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.