Error running talos INSTALL.py

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: BenWa, Assigned: parkouss)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8643103 [details]
log

I get this log running python INSTALL.py using the latest tip of talos.
this looks like our unintentional dependencies on odd packages.  There is a patch to remove this dependency, I suspect it is ready to land. :parkouss, let me know what I can do to help get the mozlog removal patch landed :)
Flags: needinfo?(j.parkouss)
(Assignee)

Comment 2

3 years ago
It's on try in bug 1189714, we should be able to land that soon.
Depends on: 1189714
Flags: needinfo?(j.parkouss)
See Also: → bug 1189847
(Assignee)

Comment 3

3 years ago
This should be better now - Benoit, can you confirm ?
Flags: needinfo?(bgirard)
(Reporter)

Comment 4

3 years ago
Created attachment 8643185 [details]
log2

Doesn't appear to be as of b6589aef27a5.
Flags: needinfo?(bgirard)
(Assignee)

Comment 5

3 years ago
Indeed, there are other errors now. mozlog is required everywhere, and with >= VERSION. As mozversion 3.0 is available but not compatible with the talos dependencies, this ends up in a mess.

We should update our dependencies of talos to the latest versions of mozbase.
(Assignee)

Updated

3 years ago
Depends on: 1190265
(Assignee)

Comment 6

3 years ago
Created attachment 8643504 [details] [diff] [review]
deps_temp_fix.patch

As a temporary workaround, we could apply that patch. This give us time to fix dependencies issues and should allow trys to work also.

jmaher, do you mind pushing this to a simple try (just to check that mozdevice==0.29) is available on internal pypi ?

With this patch, it works well locally for me now.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8643504 - Flags: review?(jmaher)
Comment on attachment 8643504 [details] [diff] [review]
deps_temp_fix.patch

Review of attachment 8643504 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great and a reasonable fix.  We do need to test this carefully on try.
Attachment #8643504 - Flags: review?(jmaher) → review+
(Assignee)

Comment 9

3 years ago
Some errors on try, because mozdevice 0.29 not in internal pypi. :) So I asked on rely, what is available is here:

http://pypi.pub.build.mozilla.org/pub/

so I updated to use mozdevice==0.40 and re-run failed jobs (20).
(Assignee)

Comment 10

3 years ago
asked on #releng*
(Assignee)

Comment 11

3 years ago
Running pretty good so far, except for g2 tests that are busted again.

Benoit, could that be a side effect of a6529a8 or 582072d ?
(Assignee)

Comment 12

3 years ago
Created attachment 8644275 [details] [diff] [review]
deps_temp_fix.patch

updating the patch to make it works locally and on try (this is what was tested on try).

I think we are good to land this now.
Attachment #8643504 - Attachment is obsolete: true
Attachment #8644275 - Flags: review+
(Assignee)

Comment 13

3 years ago
Soory no, we should not. mozdevice 0.40 requires mozlog 3.0, so it fails locally. I have to find another one.
(Assignee)

Comment 14

3 years ago
If I require mozdevice==0.26, I get:

pkg_resources.VersionConflict: (mozdevice 0.26 (/home/jp/dev/talos/venv2/lib/python2.7/site-packages), Requirement.parse('mozdevice>=0.29'))

If I require mozdevice==0.40 or no mozdevice, we have mozlog errors, and there is no other versions in internal pypi so I am a bit blocked.



Let's wait for talos to use new packages, that will fix everything. In the mean time I updated mozversion to not require mozdevice (bug 1189847). It is already on pypi, but not on internal packages. We are waiting some marionette packages with whimboo to ask internal mirroring (multiple packages in one go).

So, forget about the patch here - talos local is broken until that. Note that you should be able to run:

python talso/run_tests.py directly as a temporary workaround.
landed this temporary dependency fix on the talos branch:
https://hg.mozilla.org/build/talos/rev/ef4be62febe2
Depends on: 1192367
(Reporter)

Comment 16

3 years ago
FYI: I have one of the version posted after Comment 4 locally and it works.
ok, this is working good and deployed!
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 18

3 years ago
FYI, now the mozbase dependencies have been updated with bug 1190265, so should be good without local patches now. :)
You need to log in before you can comment on or make changes to this bug.