1190908 - Right click on the sync picture opens about:preferences#sync

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Catalin Varga [QA][:VarCat]]

Environment:

FF 41 
Build Id: 20150804004026

FF 42
Build Id: 20150804030204
Os: Win 7 x64, Ubuntu 12.04 x86, Mac Os 10.10

STR:

1. Open the hamburger menu.
2. Right click on the label with the account sync photo.

Issue:
about:preferences#sync is opened on right click

Note: The bug is reproducible with and without a photo added to the account.

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1190908.patch

Good catch!

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8643237 [details] [diff] [review]
bug-1190908.patch

Review of attachment 8643237 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/content/panelUI.inc.xul
@@ +24,5 @@
>            <hbox id="PanelUI-fxa-status"
>                  defaultlabel="&fxaSignIn.label;"
>                  signedinTooltiptext="&fxaSignedIn.tooltip;"
>                  errorlabel="&fxaSignInError.label;"
> +                onclick="gFxAccounts.onMenuPanelClick(event);">

I'm surprised we don't just want oncommand?

Comment 3

[Edouard Oger [:eoger]]

hboxes don't have it :(

Comment 4

[Mark Hammond [:markh] [:mhammond]]

(In reply to Edouard Oger [:eoger] from comment #3)
> hboxes don't have it :(

:( OK, let's just follow the convention already used in that file - onclick="if (event.button == 1) gFxAccounts.onMenuPanelClick();"

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8643237 [details] [diff] [review]
bug-1190908.patch

Review of attachment 8643237 [details] [diff] [review]:
-----------------------------------------------------------------

Let's change this to |onclick="if (event.button == 1) gFxAccounts.onMenuPanelCommand();"| (I said onMenuPanelClick before, but I think "Command" is better given we are only handling left-click.

Comment 6

[Edouard Oger [:eoger]]

Attachment: bug-1190908.patch

Updated

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7984b02e12a2

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7984b02e12a2

Comment 9

[Catalin Varga [QA][:VarCat]]

Verified as fixed:

FF 42
Build Id: 20150809030213
OS: Win 7 x64, Mac Os X 10.10.4, Ubuntu 12.04 x85