Closed Bug 1190908 Opened 8 years ago Closed 8 years ago

Right click on the sync picture opens about:preferences#sync

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Version:
42 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- verified

People

(Reporter: VarCat, Assigned: eoger)

References

Details

Attachments

(1 file, 1 obsolete file)

bug-1190908.patch
1.41 KB, patch
markh
: review+
Details | Diff | Splinter Review 
Environment:

FF 41 
Build Id: 20150804004026

FF 42
Build Id: 20150804030204
Os: Win 7 x64, Ubuntu 12.04 x86, Mac Os 10.10

STR:

1. Open the hamburger menu.
2. Right click on the label with the account sync photo.

Issue:
about:preferences#sync is opened on right click

Note: The bug is reproducible with and without a photo added to the account.
Blocks: 1139698
Attached patch bug-1190908.patch (obsolete) — — Splinter Review 
Good catch!
Assignee: nobody → edouard.oger
Status: NEW → ASSIGNED
Attachment #8643237 - Flags: review?(markh)
Comment on attachment 8643237 [details] [diff] [review]
bug-1190908.patch

Review of attachment 8643237 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/content/panelUI.inc.xul
@@ +24,5 @@
>            <hbox id="PanelUI-fxa-status"
>                  defaultlabel="&fxaSignIn.label;"
>                  signedinTooltiptext="&fxaSignedIn.tooltip;"
>                  errorlabel="&fxaSignInError.label;"
> +                onclick="gFxAccounts.onMenuPanelClick(event);">

I'm surprised we don't just want oncommand?
hboxes don't have it :(
(In reply to Edouard Oger [:eoger] from comment #3)
> hboxes don't have it :(

:( OK, let's just follow the convention already used in that file - onclick="if (event.button == 1) gFxAccounts.onMenuPanelClick();"
Comment on attachment 8643237 [details] [diff] [review]
bug-1190908.patch

Review of attachment 8643237 [details] [diff] [review]:
-----------------------------------------------------------------

Let's change this to |onclick="if (event.button == 1) gFxAccounts.onMenuPanelCommand();"| (I said onMenuPanelClick before, but I think "Command" is better given we are only handling left-click.
Attachment #8643237 - Flags: review?(markh) → feedback+
Updated
Attachment #8643237 - Attachment is obsolete: true
Attachment #8643796 - Flags: review?(markh)
Attachment #8643796 - Flags: review?(markh) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7984b02e12a2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified as fixed:

FF 42
Build Id: 20150809030213
OS: Win 7 x64, Mac Os X 10.10.4, Ubuntu 12.04 x85
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.