Handle MOZ_NATIVE_DEVICES and MOZ_WEBRTC in Gradle build

RESOLVED FIXED

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED FIXED
3 years ago
9 months ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I found these in early try pushes for Bug 1119520.  We don't do the right thing in all of our build configurations; this ticket tracks fixing a few of them.
(Assignee)

Comment 1

3 years ago
Created attachment 8643148 [details]
MozReview Request: Bug 1190940 - Handle MOZ_NATIVE_DEVICES and MOZ_WEBRTC in Gradle build. r?skaspari

Bug 1190940 - Handle MOZ_NATIVE_DEVICES and MOZ_WEBRTC in Gradle build. r?skaspari

This is an information sharing review request.  This patch
demonstrates to ways to handle static build flags in the Java source
base.

For MOZ_NATIVE_DEVICES, we /exclude/ certain Java source files.  This
is unwieldy but works fine.

For MOZ_WEBRTC, we selectively /include/ certain Javas source
directories.  We symlink the directories into the objdir so that the
IntelliJ configuration remains entirely under the project directory --
IJ really doesn't like it when sources are outside of the project
content root.  Since two source directories declare the same package
(org.webrtc.videoengine) we can't symlink deep in the package
hierarchy.  Therefore, we add top-level source directories sibling to
src/main.
Attachment #8643148 - Flags: review?(s.kaspari)
Comment on attachment 8643148 [details]
MozReview Request: Bug 1190940 - Handle MOZ_NATIVE_DEVICES and MOZ_WEBRTC in Gradle build. r?skaspari

https://reviewboard.mozilla.org/r/14991/#review13469

Btw. there's a typo in the commit description: "This patch demonstrates t(W)o ways [..]"
Attachment #8643148 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 3

3 years ago
url:        https://hg.mozilla.org/integration/fx-team/rev/437a166ba6ed525ee544b46c58270202d79a59a1
changeset:  437a166ba6ed525ee544b46c58270202d79a59a1
user:       Nick Alexander <nalexander@mozilla.com>
date:       Tue Aug 04 10:01:26 2015 -0700
description:
Bug 1190940 - Handle MOZ_NATIVE_DEVICES and MOZ_WEBRTC in Gradle build. r=sebastian

This is an information sharing review request.  This patch
demonstrates two ways to handle static build flags in the Java source
base.

For MOZ_NATIVE_DEVICES, we /exclude/ certain Java source files.  This
is unwieldy but works fine.

For MOZ_WEBRTC, we selectively /include/ certain Javas source
directories.  We symlink the directories into the objdir so that the
IntelliJ configuration remains entirely under the project directory --
IJ really doesn't like it when sources are outside of the project
content root.  Since two source directories declare the same package
(org.webrtc.videoengine) we can't symlink deep in the package
hierarchy.  Therefore, we add top-level source directories sibling to
src/main.
(Assignee)

Updated

3 years ago
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/437a166ba6ed
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
(Assignee)

Updated

9 months ago
Component: Build Config → Build Config & IDE Support
Product: Core → Firefox for Android
Target Milestone: mozilla42 → ---
You need to log in before you can comment on or make changes to this bug.