Closed Bug 1190965 Opened 5 years ago Closed 5 years ago

nsProfileLock compile error on B2G desktop with crash reporter disabled

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
FxOS-S5 (21Aug)
Tracking Status
firefox43 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1043112 +++

The changes in bug 1043112 added some Linux syscalls to nsProfileLock.cpp that are compiled if MOZ_B2G && !MOZ_CRASHREPORTER.

However, MOZ_B2G is enabled on more OSes than Linux for B2G desktop.  Also, locally I disable crash reporter.  The leads to a compile error on OS X, at least.
Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=aosmond
Attachment #8643222 - Flags: review?(aosmond)
Comment on attachment 8643222 [details]
MozReview Request: Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=jld

Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=aosmond
Attachment #8643222 - Flags: review?(aosmond) → review?(jld)
Do we need this signal handling stuff on B2G desktop, or only on B2G devices?  If B2G desktop doesn't need it, then MOZ_WIDGET_GONK is the right ifdef.  If B2G desktop *does* need it, then we probably want a portable replacement for the signal handling — the tgkill/gettid thing can be replaced with raise(), and the si_code test needs to follow the standard: 

> If si_code is SI_USER or SI_QUEUE, [XSI] [Option Start]  or any value less than or equal to 0, [Option End]  then the signal was generated by a process

i.e., we're not guaranteed that SI_USER and SI_QUEUE are <= 0, and in practice they are on Linux but not on OS X.
Flags: needinfo?(jryans)
I am not aware of a need for this signal handling to generate a core dump on B2G desktop, so I'll change to MOZ_WIDGET_GONK.
Flags: needinfo?(jryans)
Attachment #8643222 - Attachment description: MozReview Request: Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=aosmond → MozReview Request: Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=jld
Comment on attachment 8643222 [details]
MozReview Request: Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=jld

Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=jld
Attachment #8643222 - Flags: review?(jld) → review+
https://hg.mozilla.org/mozilla-central/rev/6f51622e26fe
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
You need to log in before you can comment on or make changes to this bug.