1190965 - nsProfileLock compile error on B2G desktop with crash reporter disabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

+++ This bug was initially created as a clone of Bug #1043112 +++

The changes in bug 1043112 added some Linux syscalls to nsProfileLock.cpp that are compiled if MOZ_B2G && !MOZ_CRASHREPORTER.

However, MOZ_B2G is enabled on more OSes than Linux for B2G desktop.  Also, locally I disable crash reporter.  The leads to a compile error on OS X, at least.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=jld

Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=aosmond

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76fa05b49b30

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8643222 [details]
MozReview Request: Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=jld

Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=aosmond

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Do we need this signal handling stuff on B2G desktop, or only on B2G devices?  If B2G desktop doesn't need it, then MOZ_WIDGET_GONK is the right ifdef.  If B2G desktop *does* need it, then we probably want a portable replacement for the signal handling — the tgkill/gettid thing can be replaced with raise(), and the si_code test needs to follow the standard: 

> If si_code is SI_USER or SI_QUEUE, [XSI] [Option Start]  or any value less than or equal to 0, [Option End]  then the signal was generated by a process

i.e., we're not guaranteed that SI_USER and SI_QUEUE are <= 0, and in practice they are on Linux but not on OS X.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I am not aware of a need for this signal handling to generate a core dump on B2G desktop, so I'll change to MOZ_WIDGET_GONK.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8643222 [details]
MozReview Request: Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=jld

Bug 1190965 - Restrict syscalls in nsProfileLock to Linux. r=jld

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=defa3a66f26f

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/6f51622e26fe

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f51622e26fe