1190975 - Do not dump logcat or device info when Android mochitests are run from mach

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

runtestsremote.py dumps verbose device information (process list, etc) and the logcat whenever mochitests are run. In treeherder logs, this is sometimes useful and important; when mochitests are run locally, it seems more of a bother: test results are lost in the stream of excess information.

A few weeks ago, I changed the robocop test harness to not dump device info or logcat when run from mach. I find the change delightful: Test results are clearly visible without scrolling or grep-ing; if device info or logcat are required, I just use adb.

Let's update runtestsremote.py to not dump device info or logcat when run from mach, so Android mochitests logs behave like robocop.

I would like to do the same for reftests, but there are complications; I'll leave that for another bug.

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: do not log device info when mochitests run from mach

Just like robocop -- do not dump device info if options.log_mach is set.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8643172 [details] [diff] [review]
do not log device info when mochitests run from mach

Review of attachment 8643172 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f2f8b2f8ef4

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f2f8b2f8ef4