1191018 - Uninstall un-signed Heartbeat Experiments before Firefox 41 ships

Status: RESOLVED WONTFIX

(Mozilla Labs Graveyard :: Test Pilot, defect)

Description

[Vladan Djeric (:vladan)]

We're now blocking unsigned addons, including addons which are already installed.
When the user upgrades to a Firefox version (Aurora 41 or higher) with this new policy, they will be notified that their unsigned addon is blocked and asked to find a replacement addon.

There is no need to show this notification for Mozilla-installed addons. For example, I got a notification for "Telemetry Experiment: Heartbeat Experiment 1."

This only confuses users who don't know what this add-on does or how it got installed.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Dave, do you know what needs to be done here? These are addons of type "experiment".
Can we just override that check for experiments?
Or should they be signed too?

On the plus side this only affects pre-release channels as we only run/ran experiments there.

Comment 2

[Dave Townsend [:mossop]]

Experiments were intentionally included in the set of add-ons that need to be signed as they run code. We could exclude them from the notifications we show to the user if you like?

Comment 3

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Sorry, this was aimed at me :)  

I need to write final update (self-uninstalling) addons for any outstanding tp experiments.  Old Heartbeat prototype is probably the only one.  

(Taking, plan to do the work tomorrow)

GL

Comment 4

[Dave Townsend [:mossop]]

(In reply to Gregg Lind (User Advocacy - Heartbeat - Test Pilot) from comment #3)
> Sorry, this was aimed at me :)  
> 
> I need to write final update (self-uninstalling) addons for any outstanding
> tp experiments.  Old Heartbeat prototype is probably the only one.  

I still have the tile switcher experiment installed in my profile FWIW

Comment 5

[Georg Fritzsche [:gfritzsche]]

(In reply to Dave Townsend [:mossop] from comment #4)
> (In reply to Gregg Lind (User Advocacy - Heartbeat - Test Pilot) from
> comment #3)
> > Sorry, this was aimed at me :)  
> > 
> > I need to write final update (self-uninstalling) addons for any outstanding
> > tp experiments.  Old Heartbeat prototype is probably the only one.  
> 
> I still have the tile switcher experiment installed in my profile FWIW

Do you mean showing up in about:addons in the experiments category?
The greyed out past experiments are just shown from historical data, they are not actually installed.

It looks like there are two issues here:
* old heartbeat experiment may not uninstall properly
* we should not show any notification about experiments if we don't require them to be signed

I'll file a separate bug about the notification.

Comment 6

[Georg Fritzsche [:gfritzsche]]

(In reply to Gregg Lind (User Advocacy - Heartbeat - Test Pilot) from comment #3)
> Sorry, this was aimed at me :)  
> 
> I need to write final update (self-uninstalling) addons for any outstanding
> tp experiments.  Old Heartbeat prototype is probably the only one.  

Was that an experiment without a specified end time or duration?
Otherwise experiments should be uninstalled automatically.

Comment 7

[Georg Fritzsche [:gfritzsche]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #5)
> * we should not show any notification about experiments if we don't require
> them to be signed

This is bug Bug 1191421.

Comment 8

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

so, 2 sets.

Telemetry Experiments:  Not my problem.  Should be uninstalled by the service.  (I point at Georg!)

Test Pilot Experiments:  Totally my problem :)  I think all enrollment has been stopped, and most should have autounintalled, by now.  The specific bug is for the HB one, but I will kill the others (ie deploy a self killing addon at the update), if any come up :)

Comment 9

[Georg Fritzsche [:gfritzsche]]

Ah, i wasn't aware that we still had Test Pilot experiments around.

Comment 10

[Adam Muntner [:adamm] (use NEEDINFO)]

decommissioned