119103 - Host: header not being send correctly for IPv6 IP's

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[Ilja Kamps]

Mozilla seems to wrongly assume that only IPv6 IP's in the Host: header for wich
a port is given should be encapsulated in []'s, while all (?) httpd's assume to
get it encapsulated in []'s always.

Comment 1

[Morten Nilsen]

accepting, attaching proposed patch in a second

Comment 2

[Morten Nilsen]

Attachment: proposed patch

Comment 3

[Morten Nilsen]

really taking bug this time

Comment 4

[Morten Nilsen]

giving away to reporter, as I apparently didn't understand the rfc well enough

Comment 5

[Darin Fisher]

actually, your patch doesn't solve the problem.  the problem is with the if
(port == -1) line... it skips over the [] encapsulation.

Comment 6

[Darin Fisher]

Attachment: patch

this patch should get it right... reporter: please verify.  thx!

Comment 7

[Darin Fisher]

-> reassigning to self.

Comment 8

[Morten Nilsen]

wow, darin... I was just about to attach an almost exactly equal patch ...

Comment 9

[Ilja Kamps]

That patch appaers to be a correct fix, it always encapsulates IPv6 IP's as
specified in RFC 2732

Comment 10

[Morten Nilsen]

Comment on attachment 64254 [details] [diff] [review]
patch

r=[e-mail]

Comment 11

[jag (Peter Annema)]

Comment on attachment 64254 [details] [diff] [review]
patch

>Index: nsHttpChannel.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v
>retrieving revision 1.74
>diff -u -r1.74 nsHttpChannel.cpp
>--- nsHttpChannel.cpp	8 Jan 2002 22:39:18 -0000	1.74
>+++ nsHttpChannel.cpp	10 Jan 2002 05:37:16 -0000
>@@ -172,17 +172,19 @@
>     // Set request headers
>     //
>     nsCString hostLine;

nsCAutoString would be better.

>-    if (port == -1)
>-        hostLine.Assign(host.get());
>-    else if (PL_strchr(host.get(), ':')) {
>+    if (PL_strchr(host.get(), ':')) {
>+        // host is an IPv6 address literal and must be encapsulated in []'s
>         hostLine.Assign('[');
>         hostLine.Append(host.get());

No need for .get() here.

>         hostLine.Append(']');
>-    } else {
>+    }
>+    else
>         hostLine.Assign(host.get());

Nor here.

Comment 12

[Darin Fisher]

thx jag :-)  how about an sr= with those changes?

Comment 13

[Darin Fisher]

Attachment: v2 diff - revised per jag's comments

Comment 14

[Morten Nilsen]

Comment on attachment 64329 [details] [diff] [review]
v2 diff - revised per jag's comments

>+    nsCAutoString hostLine;
>+    if (PL_strchr(host.get(), ':')) {

You forgot one it seems.

Comment 15

[Darin Fisher]

nope... that one is necessary since PL_strchr operates on a |const char *|

Comment 16

[Morten Nilsen]

Comment on attachment 64329 [details] [diff] [review]
v2 diff - revised per jag's comments

r=[e-mail]

Comment 17

[jag (Peter Annema)]

Comment on attachment 64329 [details] [diff] [review]
v2 diff - revised per jag's comments

sr=jag

Comment 18

[Darin Fisher]

fixed-on-trunk