mute the tab after restoring it from a crash if it was previously muted

VERIFIED FIXED in Firefox 42

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
Firefox 42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

4 years ago
In the pinned case, the crashed icon should take precedence, of course.
Assignee

Updated

4 years ago
Assignee: nobody → ehsan
Assignee

Updated

4 years ago
Attachment #8643306 - Flags: review?(jaws)
Assignee

Updated

4 years ago
Attachment #8643307 - Flags: review?(jaws)
Assignee

Updated

4 years ago
Keywords: leave-open
Comment on attachment 8643307 [details] [diff] [review]
Part 2: Make the crashed overlay icon for pinned tabs take priority over the muted overlay icon

Review of attachment 8643307 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/tabs.inc.css
@@ +101,5 @@
>    list-style-image: url("chrome://browser/skin/tabbrowser/crashed.svg");
>  }
>  
>  .tab-icon-overlay[soundplaying][pinned],
> +.tab-icon-overlay[muted][pinned]:not([crashed]) {

Can you combine the display:-moz-box; property here with the one above?

.tab-icon-overlay[crashed],
.tab-icon-overlay[soundplaying][pinned],
.tab-icon-overlay[muted][pinned] {
  display: -moz-box;
}

@@ +147,5 @@
>  #TabsToolbar[brighttext] .tab-icon-overlay[soundplaying][pinned]:hover:active {
>    list-style-image: url("chrome://browser/skin/tabbrowser/tab-audio-small.svg#tab-audio-pressed");
>  }
>  
> +#TabsToolbar[brighttext] .tab-icon-overlay[muted][pinned]:not([crashed]) {

Why do we need duplicate rules for #TabsToolbar[brighttext] when the list-style-image is the same here as the one when [brighttext] is not present?
Assignee

Comment 6

4 years ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> @@ +147,5 @@
> >  #TabsToolbar[brighttext] .tab-icon-overlay[soundplaying][pinned]:hover:active {
> >    list-style-image: url("chrome://browser/skin/tabbrowser/tab-audio-small.svg#tab-audio-pressed");
> >  }
> >  
> > +#TabsToolbar[brighttext] .tab-icon-overlay[muted][pinned]:not([crashed]) {
> 
> Why do we need duplicate rules for #TabsToolbar[brighttext] when the
> list-style-image is the same here as the one when [brighttext] is not
> present?

Because we don't have a suitable icon yet...  We're going to need to change these when I get a new icon.  Let's fix these when the new icon is ready to land.
Assignee

Updated

4 years ago
Attachment #8644535 - Flags: review?(jaws)
Comment on attachment 8644535 [details] [diff] [review]
Part 2: Make the crashed overlay icon for pinned tabs take priority over the muted overlay icon

Review of attachment 8644535 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds fine.
Attachment #8644535 - Flags: review?(jaws) → review+
Assignee

Updated

4 years ago
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/f8159fd0e43c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Aurora 42.0a2 (buildID: 20150826004006).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.